Implement WebDriver BiDi interception in the show file picker algorithm#11030
Merged
domenic merged 17 commits intowhatwg:mainfrom Mar 12, 2025
Merged
Implement WebDriver BiDi interception in the show file picker algorithm#11030domenic merged 17 commits intowhatwg:mainfrom
domenic merged 17 commits intowhatwg:mainfrom
Conversation
sadym-chromium
force-pushed
the
sadym/update-file-spec
branch
from
9694ffa to
091fe90
Compare
sadym-chromium
changed the title
sadym-chromium
changed the title
OrKoN
reviewed
Feb 25, 2025
Contributor
OrKoN
left a comment
OrKoN
left a comment
There was a problem hiding this comment.
LGTM % description of the issue might need updates
sadym-chromium
changed the title
sadym-chromium
changed the title
sadym-chromium
force-pushed
the
sadym/update-file-spec
branch
2 times, most recently
from
60b2e31 to
2ea78f5
Compare
sadym-chromium
added a commit
to w3c/webdriver-bidi
that referenced
this pull request
Mar 5, 2025
This PR implements `input.fileDialogOpened` event and defines `unhandledPromptBehavior` for `file`. It should be accompanied by the following changes: HTML spec: whatwg/html#11030 WebDriver Classic spec: w3c/webdriver#1884 File system access: WICG/file-system-access#452
sadym-chromium
changed the title
Contributor
Author
|
@domenic could you please take a look? |
domenic
approved these changes
Mar 10, 2025
Member
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
LGTM with nits. Please also join the @googlers GitHub organization so that the participation checker can validate your contribution.
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 10, 2025
`Page.setInterceptFileChooserDialog` only suppressed or ignores a file dialog. However, the HTML spec requires [1] to cancel the dialog in case it is dismissed by WebDriver BiDi session [2]. This CL extends `Page.setInterceptFileChooserDialog`: additionally to "suppress" and "ignore" behavior, the "cancel" behavior is added, so that the HTML spec can be implemnented. [1] whatwg/html#11030 [2] https://w3c.github.io/webdriver-bidi/#webdriver-bidi-file-dialog-opened Bug: 401188018 Change-Id: I15c612bd44a3fdfc6a15e67e33985535177b8e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330401 Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Maksim Sadym <sadym@chromium.org> Reviewed-by: Maksim Sadym <sadym@chromium.org> Cr-Commit-Position: refs/heads/main@{#1430223}
sadym-chromium
force-pushed
the
sadym/update-file-spec
branch
from
09af8ad to
1d02e03
Compare
Contributor
Author
|
@domenic could you please approve the "build" step? |
domenic
reviewed
Mar 11, 2025
Member
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
Why do you need me to approve the build step? You can build locally.
Contributor
Author
I thought it is required for being merged, but apparently not. No problem ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement WebDriver BiDi interception in the show file picker algorithm.
input.fileDialogOpened.input.fileDialogOpened+unhandledPromptBehavior:fileGoogleChromeLabs/chromium-bidi#3187(See WHATWG Working Mode: Changes for more details.)
Re-create #9844
/acknowledgements.html ( diff )
/infrastructure.html ( diff )
/input.html ( diff )