Automate file dialog via WebDriver BiDi#452
Merged
Conversation
sadym-chromium
added a commit
to w3c/webdriver-bidi
that referenced
this pull request
Mar 5, 2025
This PR implements `input.fileDialogOpened` event and defines `unhandledPromptBehavior` for `file`. It should be accompanied by the following changes: HTML spec: whatwg/html#11030 WebDriver Classic spec: w3c/webdriver#1884 File system access: WICG/file-system-access#452
|
sadym-chromium marked as non substantive for IPR from ash-nazg. |
|
sadym-chromium marked as substantive for IPR from ash-nazg. |
sadym-chromium
changed the title
a-sully
approved these changes
Mar 17, 2025
Collaborator
a-sully
left a comment
a-sully
left a comment
There was a problem hiding this comment.
LGTM once comments are addressed
Eventually it would be nice if WebDriver's filePickerOptions supported more than just "multiple" (e.g. suggestedName) but I'm happy to see this hook being added and we can always add more support to that dictionary later
Contributor
Author
|
@a-sully do you know who can merge the PR? |
Collaborator
Co-authored-by: Austin Sullivan <asully@google.com>
Co-authored-by: Austin Sullivan <asully@google.com>
Co-authored-by: Austin Sullivan <asully@google.com>
sadym-chromium
force-pushed
the
sadym/webdriver-bidi
branch
from
57e3766 to
10ccb32
Compare
Contributor
Author
rebased. Please approve the CI |
github-actions bot
added a commit
that referenced
this pull request
Mar 17, 2025
* Respect "dismissed" from "WebDriver BiDi file dialog opened" * showDirectoryPicker * Pass |File Picker Options| to "WebDriver BiDi file dialog opened" * remove "directory" * fix reference to BiDi spec * Update index.bs Co-authored-by: Austin Sullivan <asully@google.com> * Update index.bs Co-authored-by: Austin Sullivan <asully@google.com> * Update index.bs Co-authored-by: Austin Sullivan <asully@google.com> * filePickerOptions --------- Co-authored-by: Austin Sullivan <asully@google.com> SHA: f57532d Reason: push, by @a-sully Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for automating file picker: w3c/webdriver-bidi#883
Preview | Diff