Linkification in IndexUnicodeProperties & ExtraProperty(Value)Aliases #1263
Conversation
|
Wowza... @macchiati will like this :-) |
| // Link_Bracket | ||
| public enum Link_Term_Values implements Named { |
There was a problem hiding this comment.
Weird: These two lines don't go together.
Not a regression here because I see that the next section has the same problem:
// Lowercase_Mapping
public enum Math_Class_Values implements Named {
There was a problem hiding this comment.
Yeah, for non-enumerated values the generator emits a comment. It should probably invest in a new line, so that the comment does not look like it is about the next enumerated type…
|
Except: It looks like adding the new properties without updating a bunch of propertywise tests breaks those... |
|
Looks like this breaks the comparison tests because it is actually 17.0 data pretending to be for 18.0 (so new characters get linkification properties derived from their unassignedness, but their comparanda have meaningful linkification properties). |
ok |
| new UnicodeSet( | ||
| "[\\p{XID_Continue}\\p{block=basic_latin}-\\p{Cc}]", | ||
| new ParsePosition(0), | ||
| VersionedSymbolTable.frozenAt(Settings.LATEST_VERSION_INFO)) |
There was a problem hiding this comment.
Should the version here be sensitive to the new flag?
unicodetools/src/main/java/org/unicode/utilities/LinkUtilities.java
Outdated
Show resolved
Hide resolved
3 participants
See it in staging: https://unicode-jsps-staging-o2ookmn2oq-uc.a.run.app/UnicodeJsps/list-unicodeset.jsp?a=%5B%3AP%3A%5D&g=Link_Term+Link_Email&i=Link_Bracket