Fix two bugs, each of which would pin LinkEmail to 17.0 #1266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggrobin
requested review from
macchiati and
markusicu
and removed request for
markusicu
Member
|
I'd been thinking of removing that optimization, because it is touchy. It used to be necessary, but Cpus are now enough faster and memory larger .. |
macchiati
approved these changes
Dec 24, 2025
This was referenced Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted thanks to comparison test failures in #1263.
Using ICU properties in validEmailLocalPart, and an optimization in UnicodeSetProperty which assumed unassigned code points were all alike (a rather pointless optimization for a binary property), and of course the set of unassigned code points is cached at the wrong version somewhere (I was last bitten by this static cache less than a month ago: #1035 (comment)).