Linkification data for 18, retaining a flag to regenerate 17 data until we publish #1265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
looks like spotless is unhappy |
Member
Author
|
Now it should be happy. 🐈 |
markusicu
approved these changes
Dec 24, 2025
Member
markusicu
left a comment
markusicu
left a comment
There was a problem hiding this comment.
probably squash-and-merge, or squash all but the first commit?
Member
Author
|
Probably worth keeping the first commit to make sure we don’t break the history of the 17 files; I’ll squish the rest. |
Member
Author
|
Ah, there isn’t really any history to preserve because ac0201d moved the earlier files to another directory, so might as well just squash-and-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit-by-commit. See #1263 (comment).