feat(hesai_hw_interface): use dependency-injected logger, get rid of RCLCPP dependency

[mojomex]

PR Type

• Improvement

Related Links

• feat: add a logging interface, dependency injectable loggers #233 -- based on this PR

Description

✔️ #233 has been merged, this PR is ready for merging ✔️

Use the new Nebula logger interface and pass in a concrete logger on instantiation. Output with the RCLCPP logger is identical, except for the tag having gotten longer. This can be changed if desired.

The direct RCLCPP dependency of the HW interface is thus removed 🎉

Before:

After:

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• (Optional) Unit tests have been written for new behavior
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR: Required to pass before the merge.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (77b4c6c) to head (755d722).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../nebula_hesai_hw_interfaces/hesai_hw_interface.cpp	0.00%	54 Missing ⚠️
nebula_ros/src/hesai/hw_interface_wrapper.cpp	0.00%	2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (77b4c6c) and HEAD (755d722). Click for more details.

HEAD has 2 uploads less than BASE

Flag	BASE (77b4c6c)	HEAD (755d722)
total	2	0

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #232       +/-   ##
==========================================
- Coverage   26.11%   0.00%   -26.12%     
==========================================
  Files         100      88       -12     
  Lines        9214    7941     -1273     
  Branches     2214     938     -1276     
==========================================
- Hits         2406       0     -2406     
- Misses       6419    7941     +1522     
+ Partials      389       0      -389     

Flag	Coverage Δ
differential	0.00% <0.00%> (?)
total	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[drwnz]

LGTM, apart from the header Kenzo found!

[knzo25]

LGTM ! 🎉