chore: changed cerrs to loggers and forced flush to couts#301
Closed
knzo25 wants to merge 1 commit intotier4:mainfrom
Closed
chore: changed cerrs to loggers and forced flush to couts#301knzo25 wants to merge 1 commit intotier4:mainfrom
knzo25 wants to merge 1 commit intotier4:mainfrom
Conversation
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
==========================================
- Coverage 32.70% 32.29% -0.42%
==========================================
Files 112 112
Lines 9750 9750
Branches 5016 4978 -38
==========================================
- Hits 3189 3149 -40
- Misses 5967 6020 +53
+ Partials 594 581 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
5 tasks
Collaborator
|
Since PR #233, Nebula provides a built-in way to ensure that ROS logging functions are used when launched using ROS. Since it is the more general approach (and was long overdue), would you mind closing this PR in favor of #305? 🙇 |
Collaborator
|
Thank you for your quick response! |
Collaborator
|
Closed in favor of #305. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Description
Some error were being printed as
cerrwhich in some cases is not captured by the logging system.Additionally, in ROS, stoud and stderr is sometimed not flushed so manual flushes are required.
Since we do not excessively flush, it should not be a problem
Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks