Skip to content

Conversation

@leo-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

leo-starkware commented Dec 24, 2025

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.10%. Comparing base (a9a37c2) to head (7c2a75d).

Additional details and impacted files
@@            Coverage Diff             @@
##           lifted    #1296      +/-   ##
==========================================
+ Coverage   91.97%   92.10%   +0.13%     
==========================================
  Files         119      119              
  Lines       15016    15017       +1     
  Branches    15016    15017       +1     
==========================================
+ Hits        13811    13832      +21     
+ Misses       1115     1096      -19     
+ Partials       90       89       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 7c2a75d Previous: c7d55f0 Ratio
simd barycentric_eval_at_secure_field_point 2^20 1042084 ns/iter (± 236201) 512859 ns/iter (± 19347) 2.03

This comment was automatically generated by workflow using github-action-benchmark.

CC: @gilbens-starkware

@leo-starkware leo-starkware force-pushed the leo/add_periodicity_samples branch 2 times, most recently from 9c96ac6 to 539dedc Compare December 29, 2025 14:48
@leo-starkware leo-starkware force-pushed the leo/add_periodicity_samples branch from 539dedc to 4027813 Compare December 29, 2025 15:16
@leo-starkware leo-starkware changed the base branch from leo/add_periodicity_samples to graphite-base/1296 December 30, 2025 09:50
@leo-starkware leo-starkware changed the base branch from graphite-base/1296 to lifted December 30, 2025 09:50
@leo-starkware leo-starkware requested a review from alon-f December 30, 2025 09:51
@leo-starkware leo-starkware marked this pull request as ready for review December 30, 2025 09:51
Copy link
Contributor

@alon-f alon-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@alon-f reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @leo-starkware).

@leo-starkware leo-starkware merged commit b8f5b04 into lifted Dec 31, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants