-
Notifications
You must be signed in to change notification settings - Fork 167
Change order of the alphas to the samples order. #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## lifted #1292 +/- ##
=======================================
Coverage 91.97% 91.97%
=======================================
Files 119 119
Lines 14966 14959 -7
Branches 14966 14959 -7
=======================================
- Hits 13765 13759 -6
+ Misses 1111 1110 -1
Partials 90 90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
86a1033 to
6e4cd32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 555c00e | Previous: 2a2c27f | Ratio |
|---|---|---|---|
cpu polynomial commitment 2^20 |
3452607350 ns/iter (± 13869581) |
1502751321 ns/iter (± 2911465) |
2.30 |
This comment was automatically generated by workflow using github-action-benchmark.
dab9ba4 to
555c00e
Compare
555c00e to
65bbd8b
Compare
|
Define a struct for that. Code quote: (usize, SecureField, SecureField) |
65bbd8b to
b0822f8
Compare
leo-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leo-starkware made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware).
crates/stwo/src/core/pcs/quotients.rs line 58 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
Define a struct for that.
Done (open to other names for the struct)
ilyalesokhin-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilyalesokhin-starkware reviewed 6 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @leo-starkware).

No description provided.