Skip to content

Conversation

@leo-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

leo-starkware commented Dec 23, 2025

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.97%. Comparing base (1ec0705) to head (b0822f8).

Additional details and impacted files
@@           Coverage Diff           @@
##           lifted    #1292   +/-   ##
=======================================
  Coverage   91.97%   91.97%           
=======================================
  Files         119      119           
  Lines       14966    14959    -7     
  Branches    14966    14959    -7     
=======================================
- Hits        13765    13759    -6     
+ Misses       1111     1110    -1     
  Partials       90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leo-starkware leo-starkware force-pushed the leo/order_of_alphas branch 3 times, most recently from 86a1033 to 6e4cd32 Compare December 23, 2025 13:11
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 555c00e Previous: 2a2c27f Ratio
cpu polynomial commitment 2^20 3452607350 ns/iter (± 13869581) 1502751321 ns/iter (± 2911465) 2.30

This comment was automatically generated by workflow using github-action-benchmark.

CC: @gilbens-starkware

@ilyalesokhin-starkware
Copy link
Collaborator

crates/stwo/src/core/pcs/quotients.rs line 58 at r1 (raw file):

    /// The sampled column indices, their values at the point, and the random coefficient power
    /// corresponding to the fri quotient associated with (column_index, value).
    pub cols_vals_randpows: Vec<(usize, SecureField, SecureField)>,

Define a struct for that.

Code quote:

(usize, SecureField, SecureField)

Copy link
Contributor Author

@leo-starkware leo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leo-starkware made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware).


crates/stwo/src/core/pcs/quotients.rs line 58 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

Define a struct for that.

Done (open to other names for the struct)

Copy link
Collaborator

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ilyalesokhin-starkware reviewed 6 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @leo-starkware).

@leo-starkware leo-starkware merged commit 6dea951 into lifted Dec 29, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants