Change queried values layout.

[leo-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[leo-starkware]

• Add dummy serde and reexport MerkleHasherLifted. #1297
• Fix lifting size in fri_answers and add test. #1296
• Add periodicity samples. #1294
• Change queried values layout. #1293 👈 (View in Graphite)
• Change order of the alphas to the samples order. #1292
• lifted

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 98.85057% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.95%. Comparing base (6dea951) to head (a442e4a).
⚠️ Report is 1 commits behind head on lifted.

Files with missing lines	Patch %	Lines
crates/stwo/src/core/vcs_lifted/verifier.rs	96.55%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           lifted    #1293      +/-   ##
==========================================
- Coverage   91.97%   91.95%   -0.02%     
==========================================
  Files         119      119              
  Lines       14959    14974      +15     
  Branches    14959    14974      +15     
==========================================
+ Hits        13759    13770      +11     
- Misses       1110     1114       +4     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite	Current: cf74d17	Previous: 2a2c27f	Ratio
cpu polynomial commitment 2^20	3539673391 ns/iter (± 59228169)	1502751321 ns/iter (± 2911465)	2.36

This comment was automatically generated by workflow using github-action-benchmark.

CC: @gilbens-starkware

[ilyalesokhin-starkware]

crates/stwo/src/core/fri.rs line 463 at r2 (raw file):

        // The correct type for `decommitmented_values` is `SecureColumnByCoords<CpuBackend>`,
        // however since this is verifier code, we cannot use types from the prover module.

Suggestion:

        // A QM31 column is committed as 4 M31 columns.

[ilyalesokhin-starkware]

crates/stwo/src/core/vcs_lifted/verifier.rs line 133 at r2 (raw file):

            let row: Vec<_> = sorted_queries_iter
                .iter_mut()
                .map(|col_iter| *col_iter.next().unwrap())

Do we need to check that the iterators are empty after the last iteration?

Code quote:

*col_iter.next()

[ilyalesokhin-starkware]

@ilyalesokhin-starkware reviewed 4 files and all commit messages.
Reviewable status: 4 of 7 files reviewed, 2 unresolved discussions (waiting on @leo-starkware).

[leo-starkware]

@leo-starkware made 1 comment.
Reviewable status: 4 of 7 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware).

---

crates/stwo/src/core/vcs_lifted/verifier.rs line 133 at r2 (raw file):

Previously, ilyalesokhin-starkware wrote…

Do we need to check that the iterators are empty after the last iteration?

This is checked in crates/stwo/src/core/pcs/quotients.rs:125, but maybe it's indeed better here. WDYT?

[leo-starkware]

@leo-starkware made 2 comments.
Reviewable status: 4 of 7 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware).

---

crates/stwo/src/core/vcs_lifted/verifier.rs line 133 at r2 (raw file):

Previously, leo-starkware wrote…

This is checked in crates/stwo/src/core/pcs/quotients.rs:125, but maybe it's indeed better here. WDYT?

Added

---

crates/stwo/src/core/fri.rs line 463 at r2 (raw file):

        // The correct type for `decommitmented_values` is `SecureColumnByCoords<CpuBackend>`,
        // however since this is verifier code, we cannot use types from the prover module.

Done. Also changed the type from vec to array

[ilyalesokhin-starkware]

@ilyalesokhin-starkware reviewed 2 files, made 1 comment, and resolved 2 discussions.
Reviewable status: 6 of 7 files reviewed, all discussions resolved.

[leo-starkware]

@leo-starkware reviewed 2 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @leo-starkware).