Skip to content

fix: Fix position changing while dragging a marker#135

Merged
arturgesiarz merged 6 commits intomainfrom
128-dragging-problem
Feb 9, 2026
Merged

fix: Fix position changing while dragging a marker#135
arturgesiarz merged 6 commits intomainfrom
128-dragging-problem

Conversation

@arturgesiarz
Copy link
Member

No description provided.

@arturgesiarz
Copy link
Member Author

arturgesiarz commented Feb 4, 2026

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for handling marker drag events by introducing an onMarkerDragEnd callback parameter throughout the Map API. The implementation fixes an issue where marker positions would change incorrectly during dragging.

Changes:

  • Added onMarkerDragEnd callback parameter to all Map function signatures across platforms
  • Implemented drag event handling in the Android implementation using MarkerState.isDragging
  • Updated coordinate conversion utilities to support bidirectional conversion between LatLng and Coordinates
  • Added documentation note about draggability limitations when clustering is enabled

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
sample/src/commonMain/kotlin/com/swmansion/kmpmaps/sample/MapWrapper.kt Threads the new onMarkerDragEnd callback through the sample Map wrapper
kmp-maps/google-maps/src/jvmMain/kotlin/com/swmansion/kmpmaps/googlemaps/Map.kt Adds onMarkerDragEnd parameter to JVM Google Maps implementation
kmp-maps/google-maps/src/iosMain/kotlin/com/swmansion/kmpmaps/googlemaps/Map.kt Adds onMarkerDragEnd parameter to iOS Google Maps implementation
kmp-maps/google-maps/src/commonMain/kotlin/com/swmansion/kmpmaps/googlemaps/Map.kt Adds onMarkerDragEnd parameter and documentation to common Google Maps API
kmp-maps/google-maps/src/androidMain/kotlin/com/swmansion/kmpmaps/googlemaps/Map.kt Adds onMarkerDragEnd parameter to Android Google Maps implementation
kmp-maps/core/src/jvmMain/kotlin/com/swmansion/kmpmaps/core/Map.kt Adds onMarkerDragEnd parameter to JVM core implementation
kmp-maps/core/src/iosMain/kotlin/com/swmansion/kmpmaps/core/Map.kt Adds onMarkerDragEnd parameter to iOS core implementation
kmp-maps/core/src/commonMain/kotlin/com/swmansion/kmpmaps/core/Map.kt Adds onMarkerDragEnd parameter and documentation to common API
kmp-maps/core/src/commonMain/kotlin/com/swmansion/kmpmaps/core/AndroidMapTypes.kt Documents draggability limitation when clustering is enabled
kmp-maps/core/src/androidMain/kotlin/com/swmansion/kmpmaps/core/Map.kt Implements drag event handling with LaunchedEffect monitoring isDragging state and updates marker click handlers to use current position
kmp-maps/core/src/androidMain/kotlin/com/swmansion/kmpmaps/core/Extensions.kt Adds toCoordinates() extension and refactors marker state conversion for reusability

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Base automatically changed from 131-remove-id-property to main February 9, 2026 07:12
@arturgesiarz arturgesiarz merged commit 46e2cff into main Feb 9, 2026
2 checks passed
@arturgesiarz arturgesiarz deleted the 128-dragging-problem branch February 9, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No position updates when dragging a marker

3 participants