fix: Remove id property from core models and generate identifiers on-the-fly

[arturgesiarz]

No description provided.

[arturgesiarz]

This change is part of the following stack:

• fix: Remove id property from core models and generate identifiers on-the-fly #134 ◀
  • fix: Fix position changing while dragging a marker #135

_{Change managed by git-spice.}

[Copilot]

Pull request overview

This pull request refactors the core map models to remove stored id properties and instead generate identifiers on-the-fly based on object properties. The change moves from instance-based identity (using UUID) to value-based identity (using content hashing).

Changes:

• Removed id properties from Marker, Circle, Polygon, Polyline, and Cluster data classes
• Added getId() extension functions that compute IDs using contentDeepHashCode of object properties
• Introduced ClusterJS DTO for JVM platform to preserve JavaScript-generated cluster IDs
• Added @JsonIgnoreUnknownKeys to Marker for backward compatibility with JSON deserialization

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
kmp-maps/core/src/commonMain/kotlin/com/swmansion/kmpmaps/core/MapTypes.kt	Core refactoring: removed id properties from data classes and added getId() functions for Marker, Circle, Polygon, Polyline; removed Cluster id
kmp-maps/core/src/jvmMain/kotlin/com/swmansion/kmpmaps/core/MapEventHandlers.kt	Updated event handlers to use getId() calls; introduced ClusterJS DTO to handle JavaScript-generated cluster IDs
kmp-maps/core/src/jvmMain/kotlin/com/swmansion/kmpmaps/core/Extensions.kt	Updated JSON serialization to use getId() for markers, circles, polygons, and polylines
kmp-maps/core/src/iosMain/kotlin/com/swmansion/kmpmaps/core/Utils.kt	Updated cluster ID generation to use getId() for markers
kmp-maps/core/src/iosMain/kotlin/com/swmansion/kmpmaps/core/MapDelegate.kt	Updated marker lookup and image caching to use getId()
kmp-maps/core/src/iosMain/kotlin/com/swmansion/kmpmaps/core/Map.kt	Updated marker rendering and caching to use getId() with Compose key()
kmp-maps/core/src/androidMain/kotlin/com/swmansion/kmpmaps/core/Map.kt	Updated Compose key() to use getId() for markers
kmp-maps/google-maps/src/iosMain/kotlin/com/swmansion/kmpmaps/googlemaps/MarkerClusterManagerDelegate.kt	Updated marker cache lookups to use getId()
kmp-maps/google-maps/src/iosMain/kotlin/com/swmansion/kmpmaps/googlemaps/MapDelegate.kt	Updated marker lookup to use getId()
kmp-maps/google-maps/src/iosMain/kotlin/com/swmansion/kmpmaps/googlemaps/Map.kt	Updated marker rendering and caching to use getId()
kmp-maps/google-maps/src/iosMain/kotlin/com/swmansion/kmpmaps/googlemaps/Extensions.kt	Updated marker cache lookup to use getId()

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[patrickmichalik]

Let’s use @suppress for the @RestrictTo-annotated functions so that Dokka skips them.