Modify fan speed control and heat/cool sizing factors for SWHC046 by unbiya · Pull Request #37 · simularis/DEER-Prototypes-EnergyPlus

unbiya · 2025-09-17T01:32:26Z

Pull Request (PR) Description

T24 Code baseline fan speed
Heating and cooling sizing factors

Main contributor Email: jmoon@solaris-technical.com

PR Author

PR Reviewer

Confirm that base and head branch names are correct
Confirm that code requirement maps to model inputs
- Note that requirements are a function of building type and climate zone. We apply that relation in the energy savings workbook rather than directly in the model setup.
Confirm that measure case is at least efficient as base case. If this cannot be confirm by reviewing inputs then confirm via energy savings.
- Energy savings are positive
Confirm no outstanding QC concerns

Notes to remember or add to official submission

Post-processing requires updated scripts at Bug fixes for commercial post-processing helper script and associated files sound-data/DEER-Prototypes-EnergyPlus#126

* Duplicate codes files from 2022 to 2025 for SFm and MFm * Updated values in T24_2025 codes files based on Final Express Terms Referring to document "Final Express Terms for the Proposed Revisions to 2025 Title 24, Parts 1 and 6" docketed on 1/22/2025. * Provided sample tool to generate residential envelope requirements (wall and roof consolidated layer approach thickness and conductivity) * Clarify non-residential roof properties (not referenced by prototypes) * Insulation calculator script cleaning * Usage documentation * Enforce IP units for R-values from input files * Catch and print errors to output file * Revised example inputs/outputs for residential insulation calculator * Created workbook reviewing residential envelope inputs from 2022 T24 inputs * Vintage compression by Amine Lazrak 2024-03-17

…at and cool sizing factors

nfette

Questions regarding changes described in scope

Can you confirm my assumption that the VarFan variations were added only for TechIDs that appear as a base case?
We should confirm that measure case techIDs are at least efficient as base case. If this cannot be confirm by reviewing inputs, then confirm via energy savings before we approve the pull request. If measure case is less efficient because base case has variable speed fan, consider upgrading measure case requirements to include variable speed fan as well.

General QC comments

Remove unused file to avoid confusion: "commercial measures\SWHC046-04 Pkg HP AC Com\SWHC046-04 Pkg HP AC Com_Ex\cases\Htl&0&cDXHP&Ex&dxHP_equip__pkgEER.csv"
"commercial measures\SWHC046-04 Pkg HP AC Com\SWHC046-04 Pkg HP AC Com_Htl_Ex\climates.csv" should point to T24_weight_averaged_ex_Htl.csv
"commercial measures\SWHC046-04 Pkg HP AC Com\SWHC046-04 Pkg HP AC Com_Htl_Ex\cases\Htl&0&cDXHP&Ex&dxHP_equip__pkgEER.csv" needs sizing factor update
for efficient editing we have a file "cDXHP.csv" to make edits to TechIDs and parameters. Please update this file first, then use 'create_hvac_copies.cmd' to automatically copy changes to other cohorts. If we need more than one variation of parameter input file, create a second template such as "cDXHP_without_VarFan.csv"There should not be a need to directly edit individual building types.

nfette · 2025-09-17T20:19:20Z

...046-04 Pkg HP AC Com/SWHC046-04 Pkg HP AC Com_Ex/cases/Asm&0&cDXHP&Ex&dxHP_equip__pkgEER.csv

-,NE-dxHP_equip-spltSEER-15.4-SEER2-9-HSPF,,2.5,2.3,,SZ-CAV,NONE,nil,3.877['in H2O'],DX-AIR,DX-AIR,PNNL,FLOATING,95['F'],NONCOINCIDENT,FIXED-DRY-BULB,4.27,CONSTANT,,,CONSTANT,0.87,4.02,,1,,,,
-,NE-dxHP_equip-spltSEER-16.3-SEER2-9.4-HSPF,,2.5,2.3,,SZ-CAV,NONE,nil,3.877['in H2O'],DX-AIR,DX-AIR,PNNL,FLOATING,95['F'],NONCOINCIDENT,FIXED-DRY-BULB,4.43,CONSTANT,,,CONSTANT,0.87,4.09,,1,,,,
-,NE-dxHP_equip-spltSEER-17.3-SEER2-9.7-HSPF,,2.5,2.3,,SZ-CAV,NONE,nil,3.877['in H2O'],DX-AIR,DX-AIR,PNNL,FLOATING,95['F'],NONCOINCIDENT,FIXED-DRY-BULB,4.56,CONSTANT,,,CONSTANT,0.87,4.13,,1,,,,
+,NE-dxAC_equip-pkgEER-14.2-IEER-TE-0.81,,1.25,1.15,,SZ-CAV,NONE,nil,3.877['in H2O'],DX-AIR,COMBUSTION,PNNL,FLOATING,95['F'],NONCOINCIDENT,FIXED-DRY-BULB,3.91,CONSTANT,,,CONSTANT,0.87,,0.81,1,,,,


(Just to demonstrate, we can use a pull request review comment to highlight a change in the pull request conversation tab.) I see the updated sizing factors of 1.25 for heating and 1.15 for cooling in this cases file. No action required.

nfette · 2025-09-17T20:29:23Z

...046-04 Pkg HP AC Com/SWHC046-04 Pkg HP AC Com_Ex/cases/ECC&0&cDXHP&Ex&dxHP_equip__pkgEER.csv

+,NE-dxAC_equip-pkgEER-14.2-IEER-TE-0.81-VarFan,,1.25,1.15,,SZ-CAV,NONE,nil,3.877['in H2O'],DX-AIR,COMBUSTION,PNNL,FLOATING,95['F'],NONCOINCIDENT,FIXED-DRY-BULB,3.91,CONSTANT,,,VARIABLE,0.87,,0.81,1,,,,
+,NE-dxAC_equip-pkgEER-13.2-IEER-TE-0.81-VarFan,,1.25,1.15,,SZ-CAV,NONE,nil,3.877['in H2O'],DX-AIR,COMBUSTION,PNNL,FLOATING,95['F'],NONCOINCIDENT,FIXED-DRY-BULB,3.74,CONSTANT,,,VARIABLE,0.87,,0.81,1,,,,
+,NE-dxAC_equip-pkgEER-14.8-IEER-TE-0.81-VarFan,,1.25,1.15,,SZ-CAV,NONE,nil,3.877['in H2O'],DX-AIR,COMBUSTION,PNNL,FLOATING,95['F'],NONCOINCIDENT,FIXED-DRY-BULB,4.07,CONSTANT,,,VARIABLE,0.87,,0.81,1,,,,


Confirming that I see the new techIDs with main_fan_speed = VARIABLE, and all other parameters matching the original, in the following cohorts:

cohort sizing factor 1.25/1.15 new TechIDs with dxAC where main_fan_speed = VARIABLE

Asm&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ❌

ECC&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ✅

EPr&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ✅

ERC&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ✅

ESe&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ✅

EUn&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ✅

Fin&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ✅

Gro&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ✅

Hsp&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ❌

Htl_Ex/Htl&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ❌ ❌

Lib&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ✅

MBT&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ❌

MLI&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ❌

Mtl&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ❌

Nrs&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ❌

OfL&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ✅

OfS&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ✅

Rel&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ❌

RFF&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ❌

RSD&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ❌

Rt3&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ✅

RtL&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ✅

RtS&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ✅

SCn&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ❌

SUn&0&cDXHP&Ex&dxHP_equip__pkgEER.csv ✅ ❌

unbiya · 2025-09-17T23:43:13Z

Questions regarding changes described in scope

Can you confirm my assumption that the VarFan variations were added only for TechIDs that appear as a base case?

Yes, VarFan variations were added only for TechIDs that are base cases in applicable building types:

NE-dxAC_equip-pkgEER-14.2-IEER-TE-0.81
NE-dxAC_equip-pkgEER-13.2-IEER-TE-0.81
NE-dxAC_equip-pkgEER-14.8-IEER-TE-0.81
NE-dxAC_equip-pkgSEER-13.4-SEER2

We should confirm that measure case techIDs are at least efficient as base case. If this cannot be confirm by reviewing inputs, then confirm via energy savings before we approve the pull request. If measure case is less efficient because base case has variable speed fan, consider upgrading measure case requirements to include variable speed fan as well.

I will confirm this via energy savings after running the simulations.

All general QC comments have been addressed in the revision.

nfette

Thank you for addressing my comments.

ncampbell10

I've added my comments.

...res/SWHC046-04 Pkg HP AC Com/SWHC046-04 Pkg HP AC Com_Ex/cases/create_hvac_copies_VarFan.cmd

...l measures/SWHC046-04 Pkg HP AC Com/SWHC046-04 Pkg HP AC Com_Ex/cases/create_hvac_copies.cmd

nfette

See comments on two files. Also:

Standard query files for the measure do not match the reference standard query (commercial measures\SWXX000-00 Measure Name\SWXX000-00 Measure Name_Ex\query.txt). This must match for compatibility with Com.py.
- commercial measures\SWHC046-04 Pkg HP AC Com\SWHC046-04 Pkg HP AC Com_Ex\query.txt
- commercial measures\SWHC046-04 Pkg HP AC Com\SWHC046-04 Pkg HP AC Com_Htl_Ex\query.txt
This branch is one commit behind main branch, specifically the updated T24 new vintage codes files. This does not impact our simulations because we use existing vintage codes (T24_weight_averaged_ex.csv).

scripts/data transformation/DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx

scripts/data transformation/revised_Com.py

nfette

During data gathering of cooling capacity, I noticed that the query file in subfolder for vintage "Ex" has queries for heating capacity and air flow rate, but not for cooling capacity. Additional tasks:

We should update the query files in subfolders to include cooling capacity and match between Ex and Htl_Ex
Update the README.md to describe the process for coil list and cooling capacity calculation (similar to SWHC027)

…ypes-EnergyPlus.git into dev-SWHC046-VarFan

nfette · 2025-10-15T17:47:13Z

See comments on two files. Also:

* Standard query files for the measure do not match the reference standard query (commercial measures\SWXX000-00 Measure Name\SWXX000-00 Measure Name_Ex\query.txt). This must match for compatibility with Com.py.
  
  * commercial measures\SWHC046-04 Pkg HP AC Com\SWHC046-04 Pkg HP AC Com_Ex\query.txt
  * commercial measures\SWHC046-04 Pkg HP AC Com\SWHC046-04 Pkg HP AC Com_Htl_Ex\query.txt

* This branch is one commit behind main branch, specifically the updated T24 new vintage codes files. This does not impact our simulations because we use existing vintage codes (T24_weight_averaged_ex.csv).

I updated the standard query files
I merged in a bugfix branch which included the latest changes from main branch

nfette · 2025-10-15T17:49:10Z

During data gathering of cooling capacity, I noticed that the query file in subfolder for vintage "Ex" has queries for heating capacity and air flow rate, but not for cooling capacity. Additional tasks:
* We should update the query files in subfolders to include cooling capacity and match between Ex and Htl_Ex

* Update the README.md to describe the process for coil list and cooling capacity calculation (similar to SWHC027)

I addressed this comment about query files
Comment about README remains open

nfette · 2025-10-21T00:16:52Z

Didn't see any activity to address my comments, so I addressed the outstanding comments about README and query files.

nfette

My QC comments have been addressed.

simularis and others added 4 commits March 25, 2025 14:15

Changed fan speed control and heat and cool sizing factors

e6209da

Added 4 baseline cases with variable fan speed control and changed he…

0a39739

…at and cool sizing factors

Changed heat and cool sizing factors

358a52b

nfette requested changes Sep 17, 2025

View reviewed changes

nfette requested a review from ncampbell10 September 17, 2025 22:25

J Moon added 4 commits September 17, 2025 16:28

Revise create_hvac_copies.cmd and cDXHP.csv file for creating case files

da49e0b

Remove unused case files

8fbe587

Update heat and cool sizing factors for Htl case file

4b5b16a

Update code file for Htl climates.csv to T24_weight_averaged_ex_Htl.csv

f3284d7

nfette approved these changes Sep 17, 2025

View reviewed changes

ncampbell10 requested changes Sep 19, 2025

View reviewed changes

Remove lines for the unused cases files

4e392b2

ncampbell10 approved these changes Sep 23, 2025

View reviewed changes

Update post-processing scripts

0cb19d5

nfette requested changes Sep 25, 2025

View reviewed changes

scripts/data transformation/DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx Show resolved Hide resolved

scripts/data transformation/revised_Com.py Outdated Show resolved Hide resolved

nfette added 2 commits September 25, 2025 15:02

Bug fix for sound-data#122

bd900f2

Debug PSQL post-process script for SWHC046

bbe1bf9

nfette requested changes Oct 8, 2025

View reviewed changes

simularis added 6 commits October 15, 2025 10:25

Update standard query files in SWHC046 for compatibility with Com.py

75cd97d

QC query files for simdata process

c2d735c

Revert unnecessary changes from 2025-09-24

355ef5a

Merge branch 'bugfix-122' of https://github.com/simularis/DEER-Protot…

40f2fa0

…ypes-EnergyPlus.git into dev-SWHC046-VarFan

Renamed query files for sizing

f9ee1d0

Simplified query files for sizing

ba13605

nfette mentioned this pull request Oct 20, 2025

SWHC046 Packaged Heat Pump Air Conditioner Commercial, Fuel Substitution - new measure sound-data/DEER-Prototypes-EnergyPlus#83

Merged

14 tasks

Document cooling coil capacity calculation process for SWHC046

e5fd52d

nfette added 3 commits October 20, 2025 16:23

Include query string for multispeed cooling coils

584b78c

Clarify arguments to insert_normunit script for SWHC046

953d804

Clarify sizing column name in SWHC046

d2632f1

nfette approved these changes Oct 21, 2025

View reviewed changes

nfette merged commit ee220c6 into SWHC046-workingcopy1 Oct 21, 2025

cohort	sizing factor 1.25/1.15	new TechIDs with dxAC where main_fan_speed = VARIABLE
Asm&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	❌
ECC&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	✅
EPr&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	✅
ERC&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	✅
ESe&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	✅
EUn&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	✅
Fin&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	✅
Gro&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	✅
Hsp&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	❌
Htl_Ex/Htl&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	❌	❌
Lib&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	✅
MBT&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	❌
MLI&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	❌
Mtl&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	❌
Nrs&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	❌
OfL&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	✅
OfS&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	✅
Rel&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	❌
RFF&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	❌
RSD&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	❌
Rt3&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	✅
RtL&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	✅
RtS&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	✅
SCn&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	❌
SUn&0&cDXHP&Ex&dxHP_equip__pkgEER.csv	✅	❌

Conversation

unbiya commented Sep 17, 2025 • edited by nfette Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request (PR) Description

PR Author

PR Reviewer

Notes to remember or add to official submission

Uh oh!

nfette left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nfette Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

nfette Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

unbiya commented Sep 17, 2025

Uh oh!

nfette left a comment

Choose a reason for hiding this comment

Uh oh!

ncampbell10 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nfette left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nfette left a comment

Choose a reason for hiding this comment

Uh oh!

nfette commented Oct 15, 2025

Uh oh!

nfette commented Oct 15, 2025

Uh oh!

nfette commented Oct 21, 2025

Uh oh!

nfette left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

unbiya commented Sep 17, 2025 •

edited by nfette

Loading

nfette left a comment •

edited

Loading

nfette left a comment •

edited

Loading