Skip to content

SWHC046 Packaged Heat Pump Air Conditioner Commercial, Fuel Substitution - new measure#83

Merged
sepideh-QEA merged 58 commits intosound-data:mainfrom
simularis:SWHC046-workingcopy1
Mar 12, 2026
Merged

SWHC046 Packaged Heat Pump Air Conditioner Commercial, Fuel Substitution - new measure#83
sepideh-QEA merged 58 commits intosound-data:mainfrom
simularis:SWHC046-workingcopy1

Conversation

@simularis
Copy link
Copy Markdown
Contributor

@simularis simularis commented Oct 17, 2024 •
edited
Loading

Pull Request (PR) Description

This pull request is to include a measure setup for SWHC046. For this measure, we have made the following setup:

  • Creates measure in a new folder, "commercial measures/SWHC046-06 Pkg HP AC Com"
  • Inputs include parameters necessary to trigger packaged HVAC configurations (split commercial AC unit integrated with gas furnace and all-electric heat pump RTU)
  • Inputs include efficiency levels (COP) and thermal efficiency for furnace
  • Bugfix identified for Coil:Heating:DX:MultiSpeed (templates/unitary.pxt)
  • Creates additional objects of type Output:Meter in hourly output file
  • Includes alternate query file to read out sizing variables for review including
    • Coil:Heating:Electric/Design Size Nominal Capacity/*
    • AirTerminal:SingleDuct:VAV:Reheat/Design Size Maximum Air Flow Rate/*
    • Coil:Heating:DX:SingleSpeed/Design Size Gross Rated Heating Capacity/*
    • Coil:Heating:DX:SingleSpeed/Design Size Rated Air Flow Rate/*

Note that this is a fuel substitution measure, so different HVAC configurations are present across base case and measure case. Hence, standard post-processing scripts are not able to calculate the savings, so some calculations were performed in the energy savings workbook references in the measure characterization.

Main contributor: @behzadsalimian

PR Author

  • Make sure the PR branch is up to date with main branch at the time of the PR submission
  • Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
  • Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
  • For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
  • Add comments in the code when necessary to facilitate the review process.
  • Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
  • For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions.
  • For a new measure, add a summary table showing total energy consumption per simulated case.

PR Reviewer

  • Conduct a thorough code review.
  • If the branch is behind the main, merge the branch locally to check for potential conflicts.
  • If a bug, locally reproduce it and compare energy consumptions before and after.
  • Explore creative ways to stress-test the code.
  • Locally check the error file and other outputs.

@simularis
Copy link
Copy Markdown
Contributor Author

simularis commented Oct 17, 2024

Internal review comments

  • Additional objects of type Output:Meter is a new behavior in hourly output file and considered a side effect that impacts other measures. Consider whether these outputs are required in calculation files. If the outputs are needed, consider creating a new parameter to control them (default off).
  • Clarify need for old style cohort names (Asm instead of Asm&cDXHP, etc.) and how savings calculations are not performed with standard scripts.

@simularis
Copy link
Copy Markdown
Contributor Author

simularis commented Jan 23, 2025

Note for engineer: Simulation runs included in energy savings calculations are dated from May 21 through May 27, 2024. It is vital that any code used in simulation is committed to the repository. For this reason, we try to follow a protocol to run simulations on a server where no code editing should occur, only syncing commits from the online repository. Please preserve or recover working files as they were on that date. Commit all changes as they were during simulation runs from May 21 - May 27. After that, do not change any files within the simulation folder and do not reuse the same folder for new projects.

@simularis
Copy link
Copy Markdown
Contributor Author

simularis commented Jan 23, 2025 •
edited
Loading

I found and committed the final set of cohorts and cases files as used to run simulations through May 27, 2024.

@simularis
Copy link
Copy Markdown
Contributor Author

simularis commented Feb 13, 2025 •
edited
Loading

A revision in progress is addressing review comments.

  • First batch of model results from May 2024 was built on D26v2024.05.23.00. Let's refer to this as "Candidate 1". I archived that version with tag SWHC046-candidate1 in the simularis fork.
  • We developed Candidate 2, including merging in main (D26v2024.12.07.02) and other changes. See simularis PR #10. We ran simulations and are calculating energy savings from Candidate 2. After reviewing the results we will update this pull request.

simularis and others added 10 commits February 18, 2025 12:42
@simularis
README file for SWHC046 processing
a2866e0
@simularis
Revise README
6399ca6
@simularis
Include measure list for SWHC046-candidate2
dd29225
@simularis
Merge pull request #10 from behzadsalimian/SWHC046-Candidate2
52f73d4 
SWHC046 model candidate 2: first round of corrections during CPUC review

Updates with this merge:

1. TRC system types pull in additional columns with default values
2. Changed the atu reheat coil from Electric Resistance to NONE to be consistent with TRC template.
3. Increase sizing factor for cooling and heating to be consistent with DEER guidance.
4. QC'd formulas for COP conversions and entered all COP with two decimal places.
@simularis
Merge pull request #12 from simularis/swhc046-candidate2-post-proc
3536afc 
Added post-processing instructions for SWHC046 model candidate 2
Changed fan speed control and heat and cool sizing factors
e6209da
Added 4 baseline cases with variable fan speed control and changed he…
0a39739 
…at and cool sizing factors
Changed heat and cool sizing factors
358a52b
Revise create_hvac_copies.cmd and cDXHP.csv file for creating case files
da49e0b
Remove unused case files
8fbe587
@nfette
Copy link
Copy Markdown
Contributor

nfette commented Oct 20, 2025

A revision is in progress and now undergoing internal review at simularis#37. Once internal QC is completed, we will commit additional changes here. The scope of the revision includes:

  1. T24 Code baseline fan speed
  2. Heating and cooling sizing factors
  3. Clarify process and supporting files to gather cooling capacity subject to measure from models

nfette and others added 13 commits October 20, 2025 16:21
@nfette
Document cooling coil capacity calculation process for SWHC046
e5fd52d
@nfette
Include query string for multispeed cooling coils
584b78c
@nfette
Clarify arguments to insert_normunit script for SWHC046
953d804
@nfette
Clarify sizing column name in SWHC046
d2632f1
@nfette
Merge pull request #37 from simularis/dev-SWHC046-VarFan
ee220c6 
Revise SWHC046 for variable speed fans, sizing factors, and normalizing unit
-Update heat/cool sizing factors from 2.5/2.3 to 1.25/1.15
-Add baseline cases with variable fan speed for applicable building types (meeting 2025 Title 24 requirements)
-Document workflow and supporting files to gather accurate cooling capacity from models to incorporate as normalizing unit
@simularis
Switch cooling capacity query from Coil:Cooling to AirLoopHVAC:Unitar…
068a79d 
…ySystem
@nfette
Convert main HVAC filter from coil to system and column "object"
08f3076
@nfette
Clarifications to SWHC046 post-processing README
c591590
@nfette
Streamline and update result_filtered script for compatibility with m…
fe2c887 
…ain HVAC object list
@nfette
Get simulation metadata in sizing_agg_filtered SWHC046
99b4293
Update query files to show just cooling capacity
76a5a17
Update README.md
122e04d
Update DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx
c89c45f
@simularis
Copy link
Copy Markdown
Contributor Author

simularis commented Dec 17, 2025

A revision is in progress now undergoing internal review at simularis#42 (document cooling capacity calculation process)

@simularis simularis marked this pull request as draft December 17, 2025 01:04
@nfette
Revert "Update DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx"
70b7558 
This reverts commit c89c45f.
@nfette
Merge pull request #42 from simularis/dev-SWHC046-VarFan
ae1ae4c 
SWHC046 - Debug cooling capacity for multispeed and 2-stage

- Add queries for unitary system cooling capacity to sizing query files
- Verify that result.py gathers desired cooling capacity results
- Add unitary systems to coil list
- Verify that results from result_filtered.py are valid via spot checks
- Verify that results from result_filtered.py are reasonably close to previous results from Coil:Cooling approach
- Update README.md to clarify command line inputs to result_filtered.py
- Revise sizing query file to include only cooling capacity and not heating capacity or floor area
@simularis simularis marked this pull request as ready for review December 27, 2025 20:56
simularis
simularis commented Feb 5, 2026
View reviewed changes
simularis
simularis commented Feb 6, 2026
View reviewed changes
commercial measures/SWHC046-06 Pkg HP AC Com/DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx
Copy link
Copy Markdown
Contributor Author

@simularis simularis Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solaris team found a new recommendation for enhancement during QC of most recent changes.
See simularis#53. This is a low priority finding that does not impact models.

@sepideh-QEA sepideh-QEA merged commit b7a80a4 into sound-data:main Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nfette nfette nfette left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simularis @nfette @sepideh-QEA @behzadsalimian