Skip to content

fix(wizard): align save button correctly when hideNavigation is true#1507

Open
ljanner wants to merge 1 commit intomainfrom
fix/wizard-save-button-alignment
Open

fix(wizard): align save button correctly when hideNavigation is true#1507
ljanner wants to merge 1 commit intomainfrom
fix/wizard-save-button-alignment

Conversation

@ljanner
Copy link
Member

@ljanner ljanner commented Feb 12, 2026

This fixes an edge case where hideNavigation is true and the previous/next buttons are hidden.

This can be tested with the wizard playground:

  1. Open the wizard playground example
  2. Disable Inline navigation
  3. Disable Show previous/next buttons
  4. Use the External navigation to go to the last step of the wizard

@ljanner ljanner requested review from a team as code owners February 12, 2026 09:37
Copilot AI review requested due to automatic review settings February 12, 2026 09:37
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an alignment issue with the 'save' button in the wizard component when navigation buttons are hidden. My review includes a suggestion to extend this fix to also cover the edge case where there is only a single step in the wizard, which presents a similar alignment problem, ensuring the button is correctly positioned in both scenarios.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a wizard footer layout edge case where, with hideNavigation enabled (previous/next hidden) and using the footer navigation layout, the Save button isn’t aligned to the end as expected.

Changes:

  • Add conditional end class to the footer Save button when hideNavigation() is true.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ljanner ljanner force-pushed the fix/wizard-save-button-alignment branch from 5e8460d to 892f63e Compare February 12, 2026 10:08
@github-actions
Copy link

ljanner added a commit that referenced this pull request Feb 12, 2026
This fixes an edge case where hideNavigation is true and the previous/next buttons are hidden. Back port of #1507.
@ljanner
Copy link
Member Author

ljanner commented Feb 12, 2026

Team is asking for a back port, I already went ahead with creating it #1515

@akashsonune akashsonune force-pushed the fix/wizard-save-button-alignment branch from 892f63e to 8f8b09f Compare February 13, 2026 07:21
@github-actions
Copy link

Code Coverage

This fixes an edge case where hideNavigation is true and the previous/next buttons are hidden.
@ljanner ljanner force-pushed the fix/wizard-save-button-alignment branch from 8f8b09f to a5c38c6 Compare February 14, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants