Skip to content

fix(wizard): align save button correctly when hideNavigation is true #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ljanner wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −0
Open

fix(wizard): align save button correctly when hideNavigation is true #1507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions projects/element-ng/wizard/si-wizard.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@
<button
type="button"
class="btn btn-primary save"
[class.end]="hideNavigation()"
[disabled]="!currentStep?.isValid() || !currentStep?.isNextNavigable()"
(click)="save()"
>{{ saveText() | translate }}</button
Expand Down
13 changes: 13 additions & 0 deletions projects/element-ng/wizard/si-wizard.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,19 @@ describe('SiWizardComponent', () => {
expect(element.querySelector('.wizard-btn-container .back')).toBeFalsy();
expect(element.querySelector('.wizard-btn-container .next')).toBeFalsy();
});

it('should align save button to end on last step when navigation is hidden', async () => {
hostComponent.inlineNavigation = false;
await runOnPushChangeDetection(fixture);

// Navigate to the last step
component.next(hostComponent.steps.length - 1);
await runOnPushChangeDetection(fixture);

const saveButton = element.querySelector('.btn.save');
expect(saveButton).toBeTruthy();
expect(saveButton).toHaveClass('end');
});
});

describe('navigation buttons in footer', () => {
Expand Down