Skip to content

fix(wizard): align save button correctly when hideNavigation is true (back port)#1515

Open
ljanner wants to merge 1 commit intorelease/48.xfrom
fix/backmerge-wizard-save-button-alignment
Open

fix(wizard): align save button correctly when hideNavigation is true (back port)#1515
ljanner wants to merge 1 commit intorelease/48.xfrom
fix/backmerge-wizard-save-button-alignment

Conversation

@ljanner
Copy link
Member

@ljanner ljanner commented Feb 12, 2026

Back port of #1507.

This fixes an edge case where hideNavigation is true and the previous/next buttons are hidden.

This fixes an edge case where hideNavigation is true and the previous/next buttons are hidden. Back port of #1507.
@ljanner ljanner requested a review from a team as a code owner February 12, 2026 15:14
Copilot AI review requested due to automatic review settings February 12, 2026 15:14
@ljanner ljanner changed the title fix(wizard): align save button correctly when hideNavigation is true fix(wizard): align save button correctly when hideNavigation is true (backport) Feb 12, 2026
@ljanner ljanner changed the title fix(wizard): align save button correctly when hideNavigation is true (backport) fix(wizard): align save button correctly when hideNavigation is true (back port) Feb 12, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Backport of #1507 to fix an alignment edge case in the Element NG wizard footer: when hideNavigation is enabled (previous/next hidden), the Save button should align to the end on the last step.

Changes:

  • Add conditional end class to the footer Save button when hideNavigation() is true.
  • Add a regression test verifying Save button alignment on the last step when navigation is hidden.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
projects/element-ng/wizard/si-wizard.component.html Applies [class.end]="hideNavigation()" to the footer Save button to align it to the end when nav buttons are hidden.
projects/element-ng/wizard/si-wizard.component.spec.ts Adds a test covering the “inline navigation off + navigation hidden + last step” alignment case.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

Code Coverage

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively resolves an alignment issue with the 'Save' button in the wizard component when navigation is hidden. The solution, which involves conditionally applying a CSS class, is clean and direct. The addition of a new unit test is commendable, as it specifically targets and verifies the fix, ensuring the component behaves as expected in this edge case. The changes are of high quality and represent a good improvement.

@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant