fix(wizard): align save button correctly when hideNavigation is true (back port)#1515
fix(wizard): align save button correctly when hideNavigation is true (back port)#1515ljanner wants to merge 1 commit intorelease/48.xfrom
Conversation
This fixes an edge case where hideNavigation is true and the previous/next buttons are hidden. Back port of #1507.
There was a problem hiding this comment.
Pull request overview
Backport of #1507 to fix an alignment edge case in the Element NG wizard footer: when hideNavigation is enabled (previous/next hidden), the Save button should align to the end on the last step.
Changes:
- Add conditional
endclass to the footer Save button whenhideNavigation()is true. - Add a regression test verifying Save button alignment on the last step when navigation is hidden.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
projects/element-ng/wizard/si-wizard.component.html |
Applies [class.end]="hideNavigation()" to the footer Save button to align it to the end when nav buttons are hidden. |
projects/element-ng/wizard/si-wizard.component.spec.ts |
Adds a test covering the “inline navigation off + navigation hidden + last step” alignment case. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request effectively resolves an alignment issue with the 'Save' button in the wizard component when navigation is hidden. The solution, which involves conditionally applying a CSS class, is clean and direct. The addition of a new unit test is commendable, as it specifically targets and verifies the fix, ensuring the component behaves as expected in this edge case. The changes are of high quality and represent a good improvement.
|
Documentation. Coverage Reports: |
Back port of #1507.
This fixes an edge case where hideNavigation is true and the previous/next buttons are hidden.