Skip to content

Dabonnie/add test header message#100

Closed
dabonnie wants to merge 2 commits intoros2:masterfrom
aws-ros-dev:dabonnie/add-test-header-message
Closed

Dabonnie/add test header message#100
dabonnie wants to merge 2 commits intoros2:masterfrom
aws-ros-dev:dabonnie/add-test-header-message

Conversation

@dabonnie
Copy link

Add test message needed by ros2/rclcpp#1080

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
@dabonnie
Copy link
Author

FYI @wjwwood @jacobperron

@jacobperron
Copy link
Member

We can't accept this PR as it introduces a circular dependency at the repository level: test_msgs (rcl_interfaces) -> std_msgs (common_interfaces) -> builtin_interfaces (rcl_interfaces).

@dabonnie
Copy link
Author

Closing this as we'll open another with your proposal (copy the message structure rather than use a dependency).

@dabonnie dabonnie closed this Apr 23, 2020
@jacobperron
Copy link
Member

Closing this as we'll open another with your proposal (copy the message structure rather than use a dependency).

Please consider generating the message directly in rclcpp. I think it will be much neater (and easily refactored) versus adding a new public message to test_msgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants