Skip to content

Allow more speed and add extra speeds to popup mode#203

Merged
polymorphicshade merged 2 commits intodevfrom
extra-speeds
May 10, 2025
Merged

Allow more speed and add extra speeds to popup mode#203
polymorphicshade merged 2 commits intodevfrom
extra-speeds

Conversation

@asandikci
Copy link
Copy Markdown
Collaborator

No description provided.

@asandikci
Copy link
Copy Markdown
Collaborator Author

(check failing bcs of #201)

@polymorphicshade polymorphicshade changed the base branch from master to dev May 10, 2025 21:57
@polymorphicshade polymorphicshade merged commit 2d8ac1e into dev May 10, 2025
1 check failed
@tuxayo
Copy link
Copy Markdown

tuxayo commented May 16, 2025

Immense thanks, on my native language, when relistening to search for something that was said, I can keep up with 3.75 speed. So this will be very usefull from time to time.

And more rarely, when searching for something visually and when the timeline preview isn't enough, greater speeds like x5 are useful too. I usually use x8 in PipePipe (it could go to x10 but it bugs and goes back to x8, it might be my phone or an exoplayer bug) but maybe the UX for selecting speeds with precision (like comming back to x1) would be too hard so x5 as a maximum is a good simple step forward 😀

@asandikci
Copy link
Copy Markdown
Collaborator Author

You're welcome. Actually It would be good if this PR will be merged to Tubular. Are you planning to open a PR in Tubular? (as I archived my fork bcs lack of time and won't merge it unfortunatelly) @klaviartur

@klaviartur
Copy link
Copy Markdown
Contributor

Yeah, I saw and figured. And yeah, I am planning to pr this to Tubular. Thanks for reaching out.
I wish you all the best for your other projects.

@asandikci asandikci mentioned this pull request Jun 6, 2025
6 tasks
@asandikci asandikci deleted the extra-speeds branch June 6, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants