Skip to content

Allow more speed and add extra speeds to popup mode #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
polymorphicshade merged 2 commits into from
May 10, 2025
+4 −2
Merged

Allow more speed and add extra speeds to popup mode #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d3952f
enhancement: allow up to 5x speed
asandikci Feb 11, 2025
3c43214
enhancement: add 2.5x and 3x speed to popup/pip player
asandikci Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/org/schabi/newpipe/player/helper/PlaybackParameterDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public class PlaybackParameterDialog extends DialogFragment {

// Minimum allowable range in ExoPlayer
private static final double MIN_PITCH_OR_SPEED = 0.10f;
private static final double MAX_PITCH_OR_SPEED = 3.00f;
private static final double MAX_PITCH_OR_SPEED = 5.00f;

private static final boolean PITCH_CTRL_MODE_PERCENT = false;
private static final boolean PITCH_CTRL_MODE_SEMITONE = true;
Expand Down
4 changes: 3 additions & 1 deletion app/src/main/java/org/schabi/newpipe/player/ui/VideoPlayerUi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,9 @@ public abstract class VideoPlayerUi extends PlayerUi implements SeekBar.OnSeekBa
public static final int SEEK_OVERLAY_DURATION = 450; // 450 millis

// other constants (TODO remove playback speeds and use normal menu for popup, too)
private static final float[] PLAYBACK_SPEEDS = {0.5f, 0.75f, 1.0f, 1.25f, 1.5f, 1.75f, 2.0f};
private static final float[] PLAYBACK_SPEEDS = {
0.5f, 0.75f, 1.0f, 1.25f, 1.5f, 1.75f, 2.0f, 2.5f, 3.0f
};

private enum PlayButtonAction {
PLAY, PAUSE, REPLAY
Expand Down
Loading