Option to adjust playback speed (tempo) via middle gesture on main player screen#200
Merged
polymorphicshade merged 2 commits intopolymorphicshade:devfrom May 10, 2025
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Collaborator
|
Apart from these I can verify that this feature works properly (in my fork) |
Contributor
Author
|
I'm sorry, I was so careless. This was done in a hurry and I naively hoped, I can just copy whole files. How do we proceed? Shall I cancel this PR and open new one only with intended changes? |
Collaborator
|
It depends on you. You can revert changes manually and force push too. |
klaviartur
force-pushed
the
feature_tempo_gesture
branch
2 times, most recently
from
47d01a4 to
26c2a45
Compare
klaviartur
force-pushed
the
feature_tempo_gesture
branch
from
26c2a45 to
6e6e6bf
Compare
Contributor
Author
|
Okay, a lot of trial and error, but seems done now. Only intended changes should appear. |
asandikci
approved these changes
Feb 9, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add third gesture area in the middle third of player screen
Add third gesture option: tempo / playback speed
Add settings item for middle gesture
Already working (for 3 weeks) and beloved (by some people) feature in MaintainTeam/LastPipeBender