fix: increase lazy-init e2e timing threshold for real-time events#547
Closed
fix: increase lazy-init e2e timing threshold for real-time events#547
Conversation
With real-time lifecycle event emission (from #545), the gap between base's skillConnected and startRun now includes other adapter setup time. Increase threshold from 50ms to 200ms to account for this. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
FL4TLiN3
added a commit
that referenced
this pull request
Feb 17, 2026
The lazyInit field existed in schemas and types but no code read it to control behavior. All hardcoded assignments set it to false, and SkillManager.fromExpert() connects all skills synchronously regardless. Remove the field, its E2E test (which tested batch event timing, not lazy initialization), and all references across 25 files. Supersedes #547. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6 tasks
Contributor
Author
|
Superseded by #548 — the lazy-init E2E test has been deleted along with the entire lazyInit feature. |
FL4TLiN3
added a commit
that referenced
this pull request
Feb 17, 2026
* refactor: remove dead lazyInit field from codebase The lazyInit field existed in schemas and types but no code read it to control behavior. All hardcoded assignments set it to false, and SkillManager.fromExpert() connects all skills synchronously regardless. Remove the field, its E2E test (which tested batch event timing, not lazy initialization), and all references across 25 files. Supersedes #547. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * refactor: delete lazy-init E2E test file Missed in previous commit when switching branches. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lazy-init.test.tsfrom 50ms to 200ms to accommodate real-time lifecycle event emission introduced in fix: connect skill adapter lifecycle events to runtime event system #545skillConnectedandstartRunnow includes time for other adapter setup (stdio spawn, MCP handshake), which can exceed 50ms on CI runnersTest plan
lazy-init.test.tspasses locally🤖 Generated with Claude Code