Skip to content

fix: increase lazy-init e2e timing threshold for real-time events #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FL4TLiN3 wants to merge 1 commit into from
Closed

fix: increase lazy-init e2e timing threshold for real-time events #547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions e2e/perstack-cli/lazy-init.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,12 @@ describe.concurrent("Lazy Init", () => {
// @perstack/base (lazyInit=false) should be connected BEFORE startRun
expect(baseSkillEvent!.timestamp).toBeLessThanOrEqual(startRunEvent!.timestamp)

// Verify that startRun happens immediately after base connects (not waiting for attacker)
// The gap between base connected and startRun should be small (< 50ms)
// Using 50ms to account for event loop, GC pauses, and CI runner variability
// Verify that startRun happens soon after base connects (not waiting for attacker)
// With real-time lifecycle events, the gap includes time for other adapter setup
// between base's skillConnected and startRun. Using 200ms to account for
// event loop, GC pauses, stdio spawn overhead, and CI runner variability.
const gapMs = startRunEvent!.timestamp - baseSkillEvent!.timestamp
expect(gapMs).toBeLessThan(50)
expect(gapMs).toBeLessThan(200)

// Run should complete successfully
const completeRunEvent = events.find((e) => e.type === "completeRun")
Expand Down