refactor: remove dead lazyInit field from codebase#548
Merged
Conversation
The lazyInit field existed in schemas and types but no code read it to control behavior. All hardcoded assignments set it to false, and SkillManager.fromExpert() connects all skills synchronously regardless. Remove the field, its E2E test (which tested batch event timing, not lazy initialization), and all references across 25 files. Supersedes #547. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
Missed in previous commit when switching branches. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lazyInitfield from all schemas, types, runtime code, and config files (25 files, -219 lines)lazy-init.test.tsE2E test andlazy-init.tomlfixture (tested batch event timing, not lazy initialization)lazyInitfrom CI workflow matrix, TOML configs, and documentationThe field existed in schemas and types but no code ever read it to control behavior —
SkillManager.fromExpert()connects all skills synchronously regardless. All hardcoded assignments set it tofalse.Supersedes #547.
Test plan
pnpm typecheck— all 23 packages passpnpm test— all unit tests passpnpm build— all packages buildpnpm format-and-lint— no new issuespnpm run validate:changeset— passedgrep -r lazyInitreturns onlyCHANGELOG.md(historical)🤖 Generated with Claude Code