Skip to content

Rotary collection: gz-cmake, gz-utils#3287

Merged
scpeters merged 10 commits intomasterfrom
scpeters/scaffold_prototype
Mar 2, 2026
Merged

Rotary collection: gz-cmake, gz-utils#3287
scpeters merged 10 commits intomasterfrom
scpeters/scaffold_prototype

Conversation

@scpeters
Copy link
Member

@scpeters scpeters commented Dec 19, 2025

Prototype of gz-rotary-* formulae, inspired by the Rotary release repos proposal in gazebo-tooling/release-tools#1446. The goal of this prototype is to show how gz-rotary-* formulae could be added that would always build against each other from the main branch and would require minimal changes when creating stable branches or releases. As such, I propose that all formula names are all prefixed with gz-rotary- (even gz-rotary-sdformat). This PR implements gz-rotary-cmake and gz-rotary-utils that install from main branch and conflict with jetty versions.

  • When new formulae are created, conflicts need to be added to the gz-rotary-* formulae, similiar to the gz-jetty-* conflicts in this prototype.
  • Currently our brew CI uses package major version number to install dependencies, so we maintain numbered aliases that point to gz-rotary-* formulae.
  • To avoid requiring an explicity version tag, this prototype uses only the head specification, which requires installing with --HEAD (see brew CI: install with --HEAD if necessary gazebo-tooling/release-tools#1451). The alternative is to use url instead of head and explicitly specify the version tag (like here).

@scpeters scpeters requested a review from azeey December 19, 2025 23:02
@scpeters scpeters changed the title Scaffold collection prototype Rotary collection prototype Feb 6, 2026
@scpeters scpeters force-pushed the scpeters/scaffold_prototype branch 2 times, most recently from fdac2cc to b571ff9 Compare February 6, 2026 22:26
@scpeters
Copy link
Member Author

scpeters commented Feb 6, 2026

I will retarget this at #3342 and create the gz-rotary-* formulae from the jetty formulae that already depend on the gz-jetty-* aliases

@scpeters scpeters force-pushed the scpeters/scaffold_prototype branch from b571ff9 to 4e699a9 Compare February 6, 2026 22:59
Base automatically changed from scpeters/jetty_aliases to master February 11, 2026 11:06
Adds gz-scaffold-cmake, gz-scaffold-utils that install
from main branch and conflict with jetty versions.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from j-rivero February 25, 2026 00:04
@azeey
Copy link
Member

azeey commented Feb 27, 2026

The ubuntu packages use just the package name without the version number, but here we're using the gz-rotary prefix. Can we avoid this? Would it be problematic if just use the unversioned package names on all platforms for Rotary?

@scpeters
Copy link
Member Author

The ubuntu packages use just the package name without the version number, but here we're using the gz-rotary prefix. Can we avoid this? Would it be problematic if just use the unversioned package names on all platforms for Rotary?

sure, let's try it

@scpeters
Copy link
Member Author

The ubuntu packages use just the package name without the version number, but here we're using the gz-rotary prefix. Can we avoid this? Would it be problematic if just use the unversioned package names on all platforms for Rotary?

sure, let's try it

done in 4a6bf3a and 68d88f9

@scpeters scpeters force-pushed the scpeters/scaffold_prototype branch from 68d88f9 to 95e1fd4 Compare February 27, 2026 18:43
@scpeters
Copy link
Member Author

The ubuntu packages use just the package name without the version number, but here we're using the gz-rotary prefix. Can we avoid this? Would it be problematic if just use the unversioned package names on all platforms for Rotary?

sure, let's try it

done in 4a6bf3a and 68d88f9

after discussion, we decided to revert this to prevent user confusion with unversioned formulae that are actually unstable

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Copy link
Member

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one question

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

opened a draft PR for updating our CI scripts to install with --HEAD

would also need to update macos github workflow scripts in each repo that has one

@scpeters
Copy link
Member Author

opened a draft PR for updating our CI scripts to install with --HEAD

would also need to update macos github workflow scripts in each repo that has one

PR is ready for review:

@scpeters scpeters marked this pull request as ready for review February 28, 2026 03:16
@scpeters scpeters changed the title Rotary collection prototype Rotary collection: gz-cmake, gz-utils Feb 28, 2026
@scpeters scpeters merged commit 3a5fe9c into master Mar 2, 2026
1 check passed
@scpeters scpeters deleted the scpeters/scaffold_prototype branch March 2, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants