Rotary collection: gz-math, gz-common#3368
Conversation
Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
|
fixes the gz-math brew CI in gazebosim/gz-math#714 (via gazebosim/gz-math#720) |
j-rivero
left a comment
j-rivero
left a comment
There was a problem hiding this comment.
Two minor comments, good to my eyes
| target_link_libraries(test_cmake gz-common::gz-common) | ||
| EOS | ||
| system "pkg-config", "gz-common" | ||
| # cflags = `pkg-config --cflags gz-common`.split |
There was a problem hiding this comment.
Is fine to leave this commented here? re-enable or removed?
There was a problem hiding this comment.
it's been broken since #2774 due to a missing fmt dependency
it's probably fixable, but I think we aren't prioritizing pkg-config support, so we haven't tried to fix it. As long as we are installing .pc files, I have left these tests commented out rather than deleting them
| pythons.each do |python| | ||
| system python.opt_libexec/"bin/python", "-c", "import gz.math" | ||
| end | ||
| system Formula["python3"].opt_libexec/"bin/python", "-c", "import gz.math" |
There was a problem hiding this comment.
out of curiosity, why is this python call different here than the ones inside the pythons.each loop?
There was a problem hiding this comment.
the pythons.each loop checks each python version declared as a dependency of this formula, which are all declared with explicit versions (like python@3.14). We also want to ensure that our bindings work with the default python3 formula in homebrew (which is defined by an alias to one specific version). I added this check after the default version was changed to python@3.14 to give us quicker notice when the default python version changes in homebrew-core if we weren't already aware
|
I'm going to merge to unblock version bump PRs but we can continue the discussion and address in follow-up PRs if needed |
3 participants
This splits out the
gz-rotary-mathandgz-rotary-commonformulae from #3363 since they are ready to merge. Also removes thefreeimagedependency from gz-rotary-common in 9cb0813 since gazebosim/gz-common#725 has merged tomain.Follow-up to #3287, part of the following issues: