Conversation
scpeters
force-pushed
the
scpeters/more_rotary_formulae
branch
2 times, most recently
from
3b3eb65 to
daa364a
Compare
scpeters
force-pushed
the
scpeters/more_rotary_formulae
branch
from
d4a8790 to
f424b27
Compare
azeey
left a comment
azeey
left a comment
There was a problem hiding this comment.
Mostly looks good, but I have a few comments about lingering major version numbers in the formulas. For a first pass, we can just bump the versions so they line up with Rotary packages, but I'd like to explore how we might remove these versions in follow up PRs.
|
thanks for the review; obviously my script for generating these is not exhaustive. I will respond to some comments and split out individual formulae that are ready to merge into separate PRs |
scpeters
force-pushed
the
scpeters/more_rotary_formulae
branch
2 times, most recently
from
0b372cc to
106976c
Compare
|
I've split out several formulae in pull requests and merged an upstream fix to remove version numbers from install paths in gazebosim/gz-plugin#203. I think we should apply the same fixes in gz-transport and gz-sim we should also remove version numbers from plugin install paths I'm going to pause on this until Friday in case anyone else wants to jump in |
scpeters
force-pushed
the
scpeters/more_rotary_formulae
branch
2 times, most recently
from
51b8d07 to
b9bf652
Compare
scpeters
force-pushed
the
scpeters/more_rotary_formulae
branch
from
eeb5930 to
0085e9b
Compare
Currently creates rotary formulae from Jetty, excluding gz-launch. Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
Also add conflicts_with existing formulae Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
scpeters
force-pushed
the
scpeters/more_rotary_formulae
branch
from
0085e9b to
5d6fa4c
Compare
| depends_on "openssl@3" | ||
| depends_on "pkgconf" | ||
| depends_on "protobuf" | ||
| depends_on "python@3.14" |
There was a problem hiding this comment.
Let's do this in a separate PR, but I noticed that the other formulas that have python bindings also depend on multipe versions of python. Should we do that for gz-sim as well?
There was a problem hiding this comment.
Some upstream changes to gz-sim would be needed first. We could start by adding support for invoking cmake directly on gz-sim's python folder (similar to gazebosim/gz-math#636 and gazebosim/gz-math#642), but we would also have to figure out how to handle the PythonSystemLoader system. Should we just support one version of python for that system?
2 participants
This adds a script for copying Jetty formulae and converting them to Rotary and uses the script to create the rest of the Rotary formulae.
Follow-up to #3287, part of the following issues: