Skip to content

[release-4.11] OCPBUGS-2730: Add ephemeral storage to kubelet system reserved args #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 9, 2022
Merged

[release-4.11] OCPBUGS-2730: Add ephemeral storage to kubelet system reserved args #3381

openshift-merge-robot merged 1 commit into from
Nov 9, 2022

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Oct 21, 2022

This is an automated cherry-pick of #3375

/assign harche

@harche
Add ephemeral storage to kubelet system reserved args
8bf71f7 
Signed-off-by: Harshal Patil <harpatil@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 21, 2022
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 21, 2022

@openshift-cherrypick-robot: Jira Issue OCPBUGS-2079 has been cloned as Jira Issue OCPBUGS-2730. Retitling PR to link against new bug.
/retitle [release-4.11] OCPBUGS-2730: Add ephemeral storage to kubelet system reserved args

Details

In response to this:

This is an automated cherry-pick of #3375

/assign harche

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.11] OCPBUGS-2079: Add ephemeral storage to kubelet system reserved args [release-4.11] OCPBUGS-2730: Add ephemeral storage to kubelet system reserved args Oct 21, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 21, 2022

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-2730, which is invalid:

  • expected dependent Jira Issue OCPBUGS-2079 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #3375

/assign harche

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2022

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.11] OCPBUGS-2730: Add ephemeral storage to kubelet system reserved args

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nee1esh
Copy link

nee1esh commented Oct 25, 2022

/retest-required

1 similar comment
@harche
Copy link
Contributor

harche commented Nov 7, 2022

/retest-required

@harche
Copy link
Contributor

harche commented Nov 7, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 7, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 7, 2022

@harche: This pull request references Jira Issue OCPBUGS-2730, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-2079 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-2079 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (schoudha@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips
Copy link
Contributor

rphillips commented Nov 7, 2022

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 7, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rphillips, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@sunilcio
Copy link

sunilcio commented Nov 9, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 9, 2022
@harche
Copy link
Contributor

harche commented Nov 9, 2022

/retest

@openshift-merge-robot openshift-merge-robot merged commit 46327eb into openshift:release-4.11 Nov 9, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 9, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-2730 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #3375

/assign harche

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2022

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-disruptive 8bf71f7 link false /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@harche
Copy link
Contributor

harche commented Nov 9, 2022

/cherry-pick release-4.10

@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Nov 9, 2022

@harche: #3381 failed to apply on top of branch "release-4.10":

Applying: Add ephemeral storage to kubelet system reserved args
Using index info to reconstruct a base tree...
M	pkg/controller/kubelet-config/helpers.go
M	templates/master/01-master-kubelet/_base/files/kubelet.yaml
M	templates/master/01-master-kubelet/_base/units/kubelet.service.yaml
M	templates/worker/01-worker-kubelet/_base/files/kubelet.yaml
M	templates/worker/01-worker-kubelet/_base/units/kubelet.service.yaml
Falling back to patching base and 3-way merge...
Auto-merging templates/worker/01-worker-kubelet/_base/units/kubelet.service.yaml
Auto-merging templates/worker/01-worker-kubelet/_base/files/kubelet.yaml
Auto-merging templates/master/01-master-kubelet/_base/units/kubelet.service.yaml
Auto-merging templates/master/01-master-kubelet/_base/files/kubelet.yaml
Auto-merging pkg/controller/kubelet-config/helpers.go
CONFLICT (content): Merge conflict in pkg/controller/kubelet-config/helpers.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add ephemeral storage to kubelet system reserved args
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harche harche mentioned this pull request Nov 10, 2022
Merged
@praveenkumar praveenkumar mentioned this pull request Dec 5, 2022
Merged
praveenkumar added a commit to praveenkumar/snc that referenced this pull request Dec 5, 2022
@praveenkumar
Add SYSTEM_RESERVED_ES value to node sizing env
b81bb71 
Looks like in case of 4.12 setting `SYSTEM_RESERVED_ES` is mandatory,
otherwise kubelet start with `--system-reserved=cpu=200m,memory=350Mi,ephemeral-storage=`
and failed with error.

```
command failed" err="failed to run Kubelet: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP][-+]?[0-9])$'"
```

This will fix https://issues.redhat.com/browse/OCPBUGS-3758 from crc
side.

MCO change: openshift/machine-config-operator@28f062b

For release-4.11: openshift/machine-config-operator#3381
praveenkumar added a commit to crc-org/snc that referenced this pull request Dec 5, 2022
@praveenkumar
Add SYSTEM_RESERVED_ES value to node sizing env
60357cf 
Looks like in case of 4.12 setting `SYSTEM_RESERVED_ES` is mandatory,
otherwise kubelet start with `--system-reserved=cpu=200m,memory=350Mi,ephemeral-storage=`
and failed with error.

```
command failed" err="failed to run Kubelet: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP][-+]?[0-9])$'"
```

This will fix https://issues.redhat.com/browse/OCPBUGS-3758 from crc
side.

MCO change: openshift/machine-config-operator@28f062b

For release-4.11: openshift/machine-config-operator#3381
cfergeau pushed a commit to cfergeau/snc that referenced this pull request May 22, 2023
@praveenkumar @cfergeau
Add SYSTEM_RESERVED_ES value to node sizing env
e85f382 
Looks like in case of 4.12 setting `SYSTEM_RESERVED_ES` is mandatory,
otherwise kubelet start with `--system-reserved=cpu=200m,memory=350Mi,ephemeral-storage=`
and failed with error.

```
command failed" err="failed to run Kubelet: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP][-+]?[0-9])$'"
```

This will fix https://issues.redhat.com/browse/OCPBUGS-3758 from crc
side.

MCO change: openshift/machine-config-operator@28f062b

For release-4.11: openshift/machine-config-operator#3381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sinnykumari sinnykumari sinnykumari approved these changes

@jkyros jkyros Awaiting requested review from jkyros

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@rphillips rphillips

@harche harche

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @openshift-ci-robot @nee1esh @harche @rphillips @sunilcio @sinnykumari @openshift-merge-robot