OCPBUGS-2079: Add ephemeral storage to kubelet system reserved args #3375

harche · 2022-10-13T09:28:58Z

Signed-off-by: Harshal Patil harpatil@redhat.com

Fixes: https://issues.redhat.com/browse/OCPBUGS-2079

- What I did
Add missing ephemeral storage value to system reserved arg of the kubelet

- How to verify it
Log into the node, and verify that kubelet process has started with the system reserved arg that has ephemeral storage

- Description for the changelog

Signed-off-by: Harshal Patil <harpatil@redhat.com>

openshift-ci-robot · 2022-10-17T08:00:24Z

@harche: This pull request references Jira Issue OCPBUGS-2079, which is invalid:

expected the bug to target the "4.12.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Signed-off-by: Harshal Patil harpatil@redhat.com

Fixes: https://issues.redhat.com/browse/OCPBUGS-2079

- What I did
Add missing ephemeral storage value to system reserved arg of the kubelet

- How to verify it
Log into the node, and verify that kubelet process has started with the system reserved arg that has ephemeral storage

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

harche · 2022-10-17T08:01:09Z

/cc @rphillips @QiWang19

harche · 2022-10-17T08:09:26Z

/jira refresh

openshift-ci-robot · 2022-10-17T08:09:31Z

@harche: This pull request references Jira Issue OCPBUGS-2079, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.0) matches configured target version for branch (4.12.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (schoudha@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

QiWang19

LGTM

harche · 2022-10-18T05:50:51Z

/retest-required

openshift-ci · 2022-10-18T08:16:09Z

@harche: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws	`28f062b`	link	false	`/test okd-scos-e2e-aws`
ci/prow/e2e-openstack	`28f062b`	link	false	`/test e2e-openstack`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rphillips · 2022-10-18T12:37:53Z

/lgtm
/approve
/retest-required

rphillips · 2022-10-18T12:46:28Z

/assign @yuqi-zhang

yuqi-zhang

lgtm. I believe the function is used for both bootstrap and in-cluster, so we should be covered there, but out of curiosity, did you test bootstrapping with this kubeletconfig?

harche · 2022-10-19T15:58:10Z

lgtm. I believe the function is used for both bootstrap and in-cluster, so we should be covered there, but out of curiosity, did you test bootstrapping with this kubeletconfig?

I launched a cluster using cluster-bot with this PR, and the functionality worked out of box in that case.

yuqi-zhang · 2022-10-19T16:00:00Z

I launched a cluster using cluster-bot with this PR, and the functionality worked out of box in that case.

Right, I meant launch a PR with a user-provided kubeletconfig as part of the bootstrap manifests that sets ephemeral storage, which I didn't know you could do via cluster-bot, but I could just be completely out of date

harche · 2022-10-19T16:32:24Z

I launched a cluster using cluster-bot with this PR, and the functionality worked out of box in that case.

Right, I meant launch a PR with a user-provided kubeletconfig as part of the bootstrap manifests that sets ephemeral storage, which I didn't know you could do via cluster-bot, but I could just be completely out of date

Oh ok, got you now. Let me test it that way. Thanks.

yuqi-zhang · 2022-10-19T22:24:17Z

Strange, I approved the PR but the approved label never applied. Let me know how that goes, and I'll try again tomorrow

harche · 2022-10-20T09:26:29Z

Strange, I approved the PR but the approved label never applied. Let me know how that goes, and I'll try again tomorrow

@yuqi-zhang I tested in the bootstrap mode but it seems all values of system reserved (i.e. cpu, memory, ephemeral storage) are dropped. We will have to re-test the changes from #2547

I used following KubeletConfig to drop in manifest folder,

apiVersion: machineconfiguration.openshift.io/v1
kind: KubeletConfig
metadata:
  name: system-reserved-config2
spec:
  machineConfigPoolSelector:
    matchLabels:
      pools.operator.machineconfiguration.openshift.io/worker: ""
  kubeletConfig:
    systemReserved:
      cpu: 500m
      memory: 500Mi
      ephemeral-storage: 15Gi

The kubelet came up with all default values for memory,cpu, ephemeral storage,

--system-reserved=cpu=500m,memory=1Gi,ephemeral-storage=1Gi

The expected values were (without the change in this PR the value for ephemeral storage won't change anyway),

 --system-reserved=cpu=500m,memory=500Mi,ephemeral-storage=1Gi

I have created a separate bug to track this issue with bootstrap mode and system reserved, https://issues.redhat.com/browse/OCPBUGS-2634

cc @QiWang19 @rphillips

harche · 2022-10-20T09:35:45Z

Hold on, I might have made some silly mistake while testing. I will retest and report back here.

harche · 2022-10-20T10:55:26Z

By mistake I used the wrong cluster for testing. I re-ran the tests using the proper cluster and it seems to be working fine. Sorry for the noise. The value of the ephemeral storage in system reserved was correctly applied in kubelet args (in bootstrap mode),

--system-reserved=cpu=500m,memory=500Mi,ephemeral-storage=15Gi

cc @yuqi-zhang

yuqi-zhang · 2022-10-20T14:42:32Z

ack, thanks for the additional testing!

/approve

openshift-ci · 2022-10-20T14:44:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, rphillips, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2022-10-20T17:26:39Z

@harche: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#3375

Jira Issue OCPBUGS-2079 has been moved to the MODIFIED state.

Details

In response to this:

Signed-off-by: Harshal Patil harpatil@redhat.com

Fixes: https://issues.redhat.com/browse/OCPBUGS-2079

- What I did
Add missing ephemeral storage value to system reserved arg of the kubelet

- How to verify it
Log into the node, and verify that kubelet process has started with the system reserved arg that has ephemeral storage

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

harche · 2022-10-21T06:00:36Z

/cherry-pick release-4.11

openshift-cherrypick-robot · 2022-10-21T06:01:24Z

@harche: new pull request created: #3381

Details

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2022

openshift-ci bot requested review from cgwalters and jkyros October 13, 2022 09:29

harche force-pushed the OCPBUGS-2079 branch from 1bdafbe to 01da40e Compare October 17, 2022 06:29

Add ephemeral storage to kubelet system reserved args

28f062b

Signed-off-by: Harshal Patil <harpatil@redhat.com>

harche force-pushed the OCPBUGS-2079 branch from 01da40e to 28f062b Compare October 17, 2022 07:37

harche changed the title ~~WIP: Add ephemeral storage to kubelet system reserved args~~ Add ephemeral storage to kubelet system reserved args Oct 17, 2022

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2022

harche changed the title ~~Add ephemeral storage to kubelet system reserved args~~ OCPBUGS-2079: Add ephemeral storage to kubelet system reserved args Oct 17, 2022

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 17, 2022

openshift-ci bot requested review from QiWang19 and rphillips October 17, 2022 08:01

QiWang19 reviewed Oct 17, 2022

View reviewed changes

openshift-ci bot assigned rphillips Oct 18, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2022

openshift-ci bot assigned yuqi-zhang Oct 18, 2022

yuqi-zhang approved these changes Oct 19, 2022

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2022

openshift-merge-robot merged commit 27b5e69 into openshift:master Oct 20, 2022

openshift-cherrypick-robot mentioned this pull request Oct 21, 2022

[release-4.11] OCPBUGS-2730: Add ephemeral storage to kubelet system reserved args #3381

Merged

OCPBUGS-2079: Add ephemeral storage to kubelet system reserved args #3375

OCPBUGS-2079: Add ephemeral storage to kubelet system reserved args #3375

Uh oh!

Conversation

harche commented Oct 13, 2022

Uh oh!

openshift-ci-robot commented Oct 17, 2022

Uh oh!

harche commented Oct 17, 2022

Uh oh!

harche commented Oct 17, 2022

Uh oh!

openshift-ci-robot commented Oct 17, 2022

Uh oh!

QiWang19 left a comment

Choose a reason for hiding this comment

Uh oh!

harche commented Oct 18, 2022

Uh oh!

openshift-ci bot commented Oct 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rphillips commented Oct 18, 2022

Uh oh!

rphillips commented Oct 18, 2022

Uh oh!

yuqi-zhang left a comment

Choose a reason for hiding this comment

Uh oh!

harche commented Oct 19, 2022

Uh oh!

yuqi-zhang commented Oct 19, 2022

Uh oh!

harche commented Oct 19, 2022

Uh oh!

yuqi-zhang commented Oct 19, 2022

Uh oh!

harche commented Oct 20, 2022

Uh oh!

harche commented Oct 20, 2022

Uh oh!

harche commented Oct 20, 2022

Uh oh!

yuqi-zhang commented Oct 20, 2022

Uh oh!

openshift-ci bot commented Oct 20, 2022

Uh oh!

openshift-ci-robot commented Oct 20, 2022

Uh oh!

harche commented Oct 21, 2022

Uh oh!

openshift-cherrypick-robot commented Oct 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

openshift-ci bot commented Oct 18, 2022 •

edited

Loading