Skip to content

Conversation

@harche
Copy link
Contributor

@harche harche commented Nov 10, 2022

This is a manual pick of #3381

Signed-off-by: Harshal Patil <harpatil@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 10, 2022
@openshift-ci-robot
Copy link
Contributor

@harche: This pull request references Jira Issue OCPBUGS-3496, which is invalid:

  • expected dependent Jira Issue OCPBUGS-2079 to target a version in 4.11.0, 4.11.z, but it targets "4.12.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual pick of #3381

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2022

@harche: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.10] OCPBUGS-3496: Add ephemeral storage to kubelet system reserved args

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harche harche changed the title [release-4.10] OCPBUGS-3496: Add ephemeral storage to kubelet system reserved args [release-4.10] OCPBUGS-3500: Add ephemeral storage to kubelet system reserved args Nov 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2022

@harche: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.10] OCPBUGS-3500: Add ephemeral storage to kubelet system reserved args

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@harche: This pull request references Jira Issue OCPBUGS-3500, which is invalid:

  • expected the bug to target the "4.10.z" version, but it targets "4.11.z" instead
  • expected dependent Jira Issue OCPBUGS-2730 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual pick of #3381

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harche
Copy link
Contributor Author

harche commented Nov 10, 2022

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@harche: This pull request references Jira Issue OCPBUGS-3500, which is invalid:

  • expected dependent Jira Issue OCPBUGS-2730 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2022
@harche
Copy link
Contributor Author

harche commented Nov 10, 2022

/retest

Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a clean cherrypick

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, rphillips, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2022
@harche
Copy link
Contributor Author

harche commented Nov 16, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 16, 2022
@openshift-ci-robot
Copy link
Contributor

@harche: This pull request references Jira Issue OCPBUGS-3500, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.10.z) matches configured target version for branch (4.10.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-2730 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-2730 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
  • bug has dependents

Requesting review from QA contact:
/cc @lyman9966

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from lyman9966 November 16, 2022 13:37
@harche
Copy link
Contributor Author

harche commented Nov 16, 2022

Seems like a clean cherrypick

/label backport-risk-assessed

Thanks @yuqi-zhang

@harche
Copy link
Contributor Author

harche commented Nov 16, 2022

/cherry-pick release-4.9

@openshift-cherrypick-robot

@harche: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sunilcio
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 18, 2022
@harche
Copy link
Contributor Author

harche commented Nov 18, 2022

/retest

@openshift-merge-robot openshift-merge-robot merged commit 863fce1 into openshift:release-4.10 Nov 18, 2022
@openshift-ci-robot
Copy link
Contributor

@harche: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-3500 has been moved to the MODIFIED state.

Details

In response to this:

This is a manual pick of #3381

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@harche: #3408 failed to apply on top of branch "release-4.9":

Applying: Add ephemeral storage to kubelet system reserved args
Using index info to reconstruct a base tree...
M	pkg/controller/kubelet-config/helpers.go
M	templates/master/01-master-kubelet/_base/files/kubelet.yaml
A	templates/master/01-master-kubelet/alibabacloud/units/kubelet.service.yaml
M	templates/worker/01-worker-kubelet/_base/files/kubelet.yaml
A	templates/worker/01-worker-kubelet/alibabacloud/units/kubelet.service.yaml
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): templates/worker/01-worker-kubelet/alibabacloud/units/kubelet.service.yaml deleted in HEAD and modified in Add ephemeral storage to kubelet system reserved args. Version Add ephemeral storage to kubelet system reserved args of templates/worker/01-worker-kubelet/alibabacloud/units/kubelet.service.yaml left in tree.
Auto-merging templates/worker/01-worker-kubelet/_base/files/kubelet.yaml
CONFLICT (modify/delete): templates/master/01-master-kubelet/alibabacloud/units/kubelet.service.yaml deleted in HEAD and modified in Add ephemeral storage to kubelet system reserved args. Version Add ephemeral storage to kubelet system reserved args of templates/master/01-master-kubelet/alibabacloud/units/kubelet.service.yaml left in tree.
Auto-merging templates/master/01-master-kubelet/_base/files/kubelet.yaml
Auto-merging pkg/controller/kubelet-config/helpers.go
CONFLICT (content): Merge conflict in pkg/controller/kubelet-config/helpers.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add ephemeral storage to kubelet system reserved args
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2022

@harche: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node d09be51 link false /test e2e-aws-single-node
ci/prow/okd-e2e-gcp-op d09be51 link false /test okd-e2e-gcp-op
ci/prow/e2e-aws-disruptive d09be51 link false /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@harche
Copy link
Contributor Author

harche commented Nov 23, 2022

/cherry-pick release-4.9

@harche harche deleted the bug-2730 branch November 23, 2022 15:10
@openshift-cherrypick-robot

@harche: #3408 failed to apply on top of branch "release-4.9":

Applying: Add ephemeral storage to kubelet system reserved args
Using index info to reconstruct a base tree...
M	pkg/controller/kubelet-config/helpers.go
M	templates/master/01-master-kubelet/_base/files/kubelet.yaml
A	templates/master/01-master-kubelet/alibabacloud/units/kubelet.service.yaml
M	templates/worker/01-worker-kubelet/_base/files/kubelet.yaml
A	templates/worker/01-worker-kubelet/alibabacloud/units/kubelet.service.yaml
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): templates/worker/01-worker-kubelet/alibabacloud/units/kubelet.service.yaml deleted in HEAD and modified in Add ephemeral storage to kubelet system reserved args. Version Add ephemeral storage to kubelet system reserved args of templates/worker/01-worker-kubelet/alibabacloud/units/kubelet.service.yaml left in tree.
Auto-merging templates/worker/01-worker-kubelet/_base/files/kubelet.yaml
CONFLICT (modify/delete): templates/master/01-master-kubelet/alibabacloud/units/kubelet.service.yaml deleted in HEAD and modified in Add ephemeral storage to kubelet system reserved args. Version Add ephemeral storage to kubelet system reserved args of templates/master/01-master-kubelet/alibabacloud/units/kubelet.service.yaml left in tree.
Auto-merging templates/master/01-master-kubelet/_base/files/kubelet.yaml
Auto-merging pkg/controller/kubelet-config/helpers.go
CONFLICT (content): Merge conflict in pkg/controller/kubelet-config/helpers.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add ephemeral storage to kubelet system reserved args
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants