[release-4.9] OCPBUGS-4051: Add ephemeral storage to kubelet system reserved args #3429

harche · 2022-11-23T16:28:32Z

This is a manual pick of #3408

Signed-off-by: Harshal Patil <harpatil@redhat.com>

openshift-ci-robot · 2022-11-23T16:28:35Z

@harche: This pull request references Jira Issue OCPBUGS-4051, which is invalid:

expected Jira Issue OCPBUGS-4051 to depend on a bug targeting a version in 4.10.0, 4.10.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual pick of #3408

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-11-23T16:28:37Z

@harche: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.10] OCPBUGS-4051: Add ephemeral storage to kubelet system reserved args

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-11-23T16:30:27Z

@harche: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.9] OCPBUGS-4051: Add ephemeral storage to kubelet system reserved args

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

harche · 2022-11-23T16:30:29Z

/jira refresh

openshift-ci-robot · 2022-11-23T16:30:37Z

@harche: This pull request references Jira Issue OCPBUGS-4051, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.9.z) matches configured target version for branch (4.9.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-3500 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-3500 targets the "4.10.z" version, which is one of the valid target versions: 4.10.0, 4.10.z
bug has dependents

Requesting review from QA contact:
/cc @lyman9966

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

harche · 2022-11-23T21:32:00Z

/retest

harche · 2022-11-24T01:59:59Z

/cc @yuqi-zhang

harche · 2022-11-24T14:57:32Z

/retest-required

yuqi-zhang

Seems fine from a sanity perspective. How far do you anticipate needing to backport this, and do we need to do any additional testing?

harche · 2022-11-25T15:11:51Z

Seems fine from a sanity perspective. How far do you anticipate needing to backport this, and do we need to do any additional testing?

Thanks @yuqi-zhang for the approval. We introduced the auto node sizing in 4.8, so these backports will have to go all the way till 4.8.

Apart from the testing QA is doing to verify the PRs, we don't need anything more than that.

yuqi-zhang · 2022-11-28T20:27:48Z

/label cherry-pick-approved
/lgtm

openshift-ci · 2022-11-28T20:27:51Z

@yuqi-zhang: Can not set label cherry-pick-approved: Must be member in one of these teams: []

Details

In response to this:

/label cherry-pick-approved
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yuqi-zhang · 2022-11-28T20:28:12Z

sorry wrong label

/label backport-risk-assessed

wking · 2022-12-07T09:48:22Z

We should resolve OCPBUGS-4101 before backporting this further.

/hold

harche · 2023-01-04T14:29:35Z

@wking https://issues.redhat.com/browse/OCPBUGS-4101 is now in verified state. Should we remove the hold from this PR?

yuqi-zhang · 2023-01-11T00:28:58Z

looking at the other chain, it is awaiting backport to 4.11: #3459

how are these interweaved again? Do we need to wait for that to get into previous versions? Or is that not directly related

harche · 2023-01-11T14:41:26Z

@yuqi-zhang When we set the system reserved values for the kubelet, we should have been setting memory, cpu and ephemeral storage values. But for some reason we were only setting memory and cpu. This PR fixes that issue and sets the missing ephemeral storage value for the kubelet.

On the other hand, #3459 makese the system reserved values more reselient against a blank (and hence invalid) input.

These two PRs are linked. (This) one introduces missing parameter and other one makes those parameters more resilient against bad input.

yuqi-zhang · 2023-01-12T00:22:05Z

Ok, so not directly conflicting in any way, I think both are now awaiting QE approval, but can otherwise be merged as needed

sunilcio · 2023-01-13T15:33:49Z

/label cherry-pick-approved

yuqi-zhang · 2023-01-14T00:07:12Z

Based on the conversation in slack, we will wait for #3487 to merge, then backport both via this PR together, does that sound correct?

harche · 2023-01-16T16:07:21Z

Based on the conversation in slack, we will wait for #3487 to merge, then backport both via this PR together, does that sound correct?

Yes, that's correct.

Signed-off-by: Harshal Patil <harpatil@redhat.com>

openshift-ci · 2023-01-26T19:13:39Z

@harche: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ovn-step-registry	`7397027`	link	false	`/test e2e-ovn-step-registry`
ci/prow/okd-e2e-upgrade	`7397027`	link	false	`/test okd-e2e-upgrade`
ci/prow/e2e-aws-upgrade-single-node	`7397027`	link	false	`/test e2e-aws-upgrade-single-node`
ci/prow/e2e-aws-workers-rhel8	`7397027`	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/4.9-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade	`7397027`	link	false	`/test 4.9-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade`
ci/prow/e2e-aws-disruptive	`7397027`	link	false	`/test e2e-aws-disruptive`
ci/prow/okd-e2e-aws	`7397027`	link	false	`/test okd-e2e-aws`
ci/prow/okd-e2e-gcp-op	`7397027`	link	false	`/test okd-e2e-gcp-op`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

yuqi-zhang · 2023-01-26T22:10:21Z

/lgtm

openshift-ci · 2023-01-26T22:10:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lyman9966 · 2023-01-30T04:12:55Z

/label qe-approved

yuqi-zhang · 2023-02-03T18:06:06Z

We have all the necessary labels, ad the other dependent bug https://issues.redhat.com//browse/OCPBUGS-5831 has been verified for 4.10

/hold cancel

openshift-ci-robot · 2023-02-03T18:46:03Z

/retest-required

Remaining retests: 0 against base HEAD b2055c0 and 2 for PR HEAD 7397027 in total

openshift-ci-robot · 2023-02-03T20:53:35Z

@harche: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#3429

Jira Issue OCPBUGS-4051 has been moved to the MODIFIED state.

Details

In response to this:

This is a manual pick of #3408

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

harche · 2023-02-07T18:50:44Z

/cherry-pick release-4.8

openshift-cherrypick-robot · 2023-02-07T18:51:24Z

@harche: #3429 failed to apply on top of branch "release-4.8":

Applying: Add ephemeral storage to kubelet system reserved args
Using index info to reconstruct a base tree...
M	pkg/controller/kubelet-config/helpers.go
M	pkg/controller/kubelet-config/kubelet_config_controller.go
M	templates/master/01-master-kubelet/_base/units/kubelet.service.yaml
M	templates/master/01-master-kubelet/on-prem/units/kubelet.service.yaml
M	templates/worker/01-worker-kubelet/_base/units/kubelet.service.yaml
M	templates/worker/01-worker-kubelet/on-prem/units/kubelet.service.yaml
Falling back to patching base and 3-way merge...
Auto-merging templates/worker/01-worker-kubelet/on-prem/units/kubelet.service.yaml
Auto-merging templates/worker/01-worker-kubelet/_base/units/kubelet.service.yaml
Auto-merging templates/master/01-master-kubelet/on-prem/units/kubelet.service.yaml
Auto-merging templates/master/01-master-kubelet/_base/units/kubelet.service.yaml
Auto-merging pkg/controller/kubelet-config/kubelet_config_controller.go
CONFLICT (content): Merge conflict in pkg/controller/kubelet-config/kubelet_config_controller.go
Auto-merging pkg/controller/kubelet-config/helpers.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add ephemeral storage to kubelet system reserved args
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yuqi-zhang · 2023-02-07T18:58:18Z

Is there anyone asking for this to go to 4.8? I think 4.8 is old enough such that this shouldn't really be necessary

harche · 2023-02-07T18:59:50Z

Is there anyone asking for this to go to 4.8? I think 4.8 is old enough such that this shouldn't really be necessary

Yeah, you are right. I won't pursue this unless someone asks for it.

Add ephemeral storage to kubelet system reserved args

94714b3

Signed-off-by: Harshal Patil <harpatil@redhat.com>

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 23, 2022

harche changed the title ~~[release-4.10] OCPBUGS-4051: Add ephemeral storage to kubelet system reserved args~~ [release-4.9] OCPBUGS-4051: Add ephemeral storage to kubelet system reserved args Nov 23, 2022

openshift-ci bot requested a review from rphillips November 23, 2022 16:30

openshift-ci bot requested review from lyman9966 and sjenning November 23, 2022 16:30

openshift-ci bot requested a review from yuqi-zhang November 24, 2022 02:00

yuqi-zhang approved these changes Nov 24, 2022

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2022

openshift-ci bot assigned yuqi-zhang Nov 28, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2022

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 28, 2022

openshift-ci bot assigned anuragthehatter, eurijon and mburman5 Nov 28, 2022

openshift-ci bot assigned sergiordlr and sunilcio Nov 28, 2022

mburman5 removed their assignment Dec 7, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2022

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 13, 2023

Do not allow empty system reserved values

7397027

Signed-off-by: Harshal Patil <harpatil@redhat.com>

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2023

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 30, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2023

openshift-merge-robot merged commit 30fd1e3 into openshift:release-4.9 Feb 3, 2023

[release-4.9] OCPBUGS-4051: Add ephemeral storage to kubelet system reserved args #3429

[release-4.9] OCPBUGS-4051: Add ephemeral storage to kubelet system reserved args #3429

Uh oh!

Conversation

harche commented Nov 23, 2022

Uh oh!

openshift-ci-robot commented Nov 23, 2022

Uh oh!

openshift-ci bot commented Nov 23, 2022

Uh oh!

openshift-ci bot commented Nov 23, 2022

Uh oh!

harche commented Nov 23, 2022

Uh oh!

openshift-ci-robot commented Nov 23, 2022

Uh oh!

harche commented Nov 23, 2022

Uh oh!

harche commented Nov 24, 2022

Uh oh!

harche commented Nov 24, 2022

Uh oh!

yuqi-zhang left a comment

Choose a reason for hiding this comment

Uh oh!

harche commented Nov 25, 2022

Uh oh!

yuqi-zhang commented Nov 28, 2022

Uh oh!

openshift-ci bot commented Nov 28, 2022

Uh oh!

yuqi-zhang commented Nov 28, 2022

Uh oh!

wking commented Dec 7, 2022

Uh oh!

harche commented Jan 4, 2023

Uh oh!

yuqi-zhang commented Jan 11, 2023

Uh oh!

harche commented Jan 11, 2023

Uh oh!

yuqi-zhang commented Jan 12, 2023

Uh oh!

sunilcio commented Jan 13, 2023

Uh oh!

yuqi-zhang commented Jan 14, 2023

Uh oh!

harche commented Jan 16, 2023

Uh oh!

openshift-ci bot commented Jan 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yuqi-zhang commented Jan 26, 2023

Uh oh!

openshift-ci bot commented Jan 26, 2023

Uh oh!

lyman9966 commented Jan 30, 2023

Uh oh!

yuqi-zhang commented Feb 3, 2023

Uh oh!

openshift-ci-robot commented Feb 3, 2023

Uh oh!

openshift-ci-robot commented Feb 3, 2023

Uh oh!

harche commented Feb 7, 2023

Uh oh!

openshift-cherrypick-robot commented Feb 7, 2023

Uh oh!

yuqi-zhang commented Feb 7, 2023

Uh oh!

harche commented Feb 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

openshift-ci bot commented Jan 26, 2023 •

edited

Loading