-
Notifications
You must be signed in to change notification settings - Fork 62
Use s prefix for multiscale example #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is a tendency to replicate the examples exactly. Having multiscale paths only being a number can be easily confused with chunk paths.
|
related: #277 |
|
Agreed that What about updating the index.html spec page itself? It contains a bunch of places that use plain integer for multiscale paths. Build failure is |
Which index.html is that? |
|
Ah, it's actually index.bs: e.g. Line 82 in 8cbba21
I got there by clicking on the "0.5" submodules link from https://github.com/ome/ngff |
|
@will-moore anything else to do here? |
|
No blockers to the changes here. cc @jo-mueller |
|
Thanks for the heads-up @will-moore . Yes, changing it here will mean it'll have to be changed over at ngff-spec, too. Since the change is minor, I think it could be added there already. Otherwise, the order of PRs that would have to go until then would be #350 --> ome/ngff-spec#17 --> this (and everything else) |
As suggested in ome/ngff#311
|
@jo-mueller I'll work on moving this to ngff-spec... |
|
PR opened: ome/ngff-spec#56 |
|
See also ome/ngff-spec#24 |
|
Ugh sorry @will-moore, I had this ported already a while ago and forgot to raise the hand here clearer 😬 My bad! |
There is a tendency to replicate the examples exactly. Having multiscale paths only being a number can be easily confused with chunk paths. Overall, the examples are being interpreted as recommended conventions so we may want to consider the implications of the names used in the examples.
This is a minor change since it just modifies the example without modification to the actual schemas. Having a path that is just a number remains valid. This would also match the existing n5 convention:
https://github.com/saalfeldlab/n5-viewer?tab=readme-ov-file#n5-viewer-metadata