-
Notifications
You must be signed in to change notification settings - Fork 6
Fix multiscale examples #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-Authored-By: Mark Kittisopikul <mkitti@users.noreply.github.com>
Automated Review URLs |
|
Hi @mkitti , no strong opinion here. In the markdown documents, jsonc metadata are flagged as jsonc documents like this: ```jsonc
{
// ...
"attributes": {
"ome": {
"version": "0.5",
// ...
}
}
}
```Tbh, I wasn't even aware that |
|
ome/ngff#311 and my duplicated version of this at #56 both had changes to |
|
@mkitti can you check whether this sorts out all of the formatting issues you raised at ome/ngff#311? @will-moore am I missing some more instances of malformating here? 🤔 |
|
#56 had changes to |
It does not. The examples have comments in what is labeled as JSON, which does not allow for comments. |
|
@will-moore would you mind merging #56 into this PR? |
|
@jo-mueller I don't mind it happening but I don't think I can push to this branch myself. I have re-opened that PR against this branch as jo-mueller#5 |
* use s0 paths for scale paths in index.md * use s0 paths for scale paths in examples json * use s0 paths for scale paths in most tests json

Mirror PR to carry ome/ngff#311 over to ngff-spec. Can be merged once that ome/ngff#311 has been merged, too, to make sure both places stay in sync and that @mkitti's contribution is acknowledged in the commit history.
Co-pilot description
This pull request updates several NGFF multiscales example JSON files to standardize dataset path naming and improve the representation of coordinate systems and transformations. The most significant changes include renaming dataset paths from numeric values to string identifiers (e.g.,
"0"→"s0"), updating transformation input references accordingly, and enhancing the structure for specifying coordinate systems in the multiscales metadata.Standardization of dataset paths and input references:
pathfields from numeric strings (e.g.,"0","1","2") to string identifiers ("s0","s1","s2") inmultiscales_example.json,multiscales_example_relative.json, andmultiscales_transformations.json. Updated all correspondinginputfields incoordinateTransformationsto match the new path names. [1] [2] [3] [4]Enhancements to coordinate system specification:
coordinateSystemssection to the multiscales metadata inmultiscales_transformations.json, explicitly defining the"intrinsic"coordinate system and its axes. [1] [2]Other metadata improvements:
namefield inmultiscales_transformations.jsonfrom"image_with_coordinateTransformations"to"image_with_multiscaleTransformations"for clarity and consistency.