Skip to content

allow utf8 characters in git commit messages#14

Open
jobevers wants to merge 1 commit intonylas:masterfrom
jobevers:utf8-git
Open

allow utf8 characters in git commit messages#14
jobevers wants to merge 1 commit intonylas:masterfrom
jobevers:utf8-git

Conversation

@jobevers
Copy link

@jobevers jobevers commented Jul 5, 2016

Fixes #13

@msabramo
Copy link

msabramo commented Oct 31, 2016

Hmmm, I'm not seeing a problem when using git master. I did a commit with a Unicode snowman (U+2603) in the commit message:

[marca@marca-mac2 smbot2]$ git log -1 --oneline
84a40df Add ☃

[marca@marca-mac2 smbot2]$ rm -rf debian; make-deb && cat debian/rules
'debian' directory successfully placed at the root of your repository
#!/usr/bin/make -f

%:
    dh $@ --with python-virtualenv%

Am I not doing the right thing to reproduce the issue?

@msabramo
Copy link

OK, I reproduced it by removing 662c6aa, which worked around the problem.

I like this better. I would vote for reverting 662c6aa and merging this PR.

@jobevers
Copy link
Author

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants