make-deb fails if the latest_git_commit contains unicode

[jobevers]

If the latest git commit message has unicode in it, this line https://github.com/nylas/make-deb/blob/master/make_deb/__init__.py#L95 will throw a UnicodeDecode error.

[msabramo]

Hmmm, I'm not seeing a problem when using git master. I did a commit with a Unicode snowman (U+2603) in the commit message:

[marca@marca-mac2 smbot2]$ git log -1 --oneline
84a40df Add ☃

[marca@marca-mac2 smbot2]$ rm -rf debian; make-deb && cat debian/rules
'debian' directory successfully placed at the root of your repository
#!/usr/bin/make -f

%:
    dh $@ --with python-virtualenv%

Am I not doing the right thing to reproduce the issue?

Or maybe the issue has already been fixed?

[msabramo]

It looks like 662c6aa fixed this issue. However, that code causes the program to fail on Python 3:

Traceback (most recent call last):
  File "/Users/marca/dev/git-repos/make-deb/bin/make-deb", line 8, in <module>
    reload(sys)

[msabramo]

OK, I reproduced it by removing 662c6aa, which worked around the problem.

I like #14 better. I would vote for reverting 662c6aa and merging #14.

[jobevers]

Thanks for digging into that.

On Mon, Oct 31, 2016 at 12:46 PM, Marc Abramowitz notifications@github.com
wrote:

OK, I reproduced it by removing 662c6aa
662c6aa,
which worked around the problem.

I like #14 #14 better. I would
vote for reverting 662c6aa
662c6aa
and merging #14 #14.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#13 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACRRXztWVZ9Nvu4ubOMTqXjcNlMBBuUQks5q5iligaJpZM4JFdgF
.