Skip to content

allow utf8 characters in git commit messages #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jobevers wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow utf8 characters in git commit messages #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions make_deb/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import codecs
import datetime
import os
from pkg_resources import resource_string
Expand Down Expand Up @@ -45,7 +46,7 @@ def _context_from_git(self):
["git", "log", "-1", "--oneline"],
cwd=self.rootdir,
stdout=subprocess.PIPE).communicate()
return {"latest_git_commit": stdout[0]}
return {"latest_git_commit": stdout[0].decode('utf-8')}
except OSError:
raise DebianConfigurationException("Please install git")
except Exception as e:
Expand Down Expand Up @@ -96,7 +97,7 @@ def render(self):
resource_string("make_deb", template).decode('utf-8')
).render(self.context)

with open(os.path.join(output_dir, filename), "w") as f:
with codecs.open(os.path.join(output_dir, filename), "w", 'utf-8') as f:
f.write(content)

# Need to to trigger separately because filename must change
Expand Down