experiment: use biome as the linter#16983
Draft
anatawa12 wants to merge 52 commits intomisskey-dev:developfrom
Draft
experiment: use biome as the linter#16983anatawa12 wants to merge 52 commits intomisskey-dev:developfrom
anatawa12 wants to merge 52 commits intomisskey-dev:developfrom
Conversation
…TypeReturn noExportsInTest
- lint/complexity/useDateNow - lint/complexity/useIndexOf - lint/complexity/useOptionalChain - lint/complexity/noStaticOnlyClass (disabled) - lint/complexity/noCommaOperator - lint/complexity/noUselessConstructor
- lint/suspicious/noConfusingVoidType (partially suppressed) - lint/suspicious/noDoubleEquals - lint/suspicious/noImplicitAnyLet - lint/suspicious/noAsyncPromiseExecutor - lint/suspicious/noFallthroughSwitchClause
scroll.test.ts: should we use document? or window.document?
Contributor
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -5112,7 +5112,7 @@
"string",
"null"
],
- "pattern": "^[a-zA-Z0-9\\/\\-*]+$"
+ "pattern": "^[a-zA-Z0-9/\\-*]+$"
},
"origin": {
"type": "string",
@@ -39052,7 +39052,7 @@
"string",
"null"
],
- "pattern": "^[a-zA-Z\\/\\-*]+$"
+ "pattern": "^[a-zA-Z/\\-*]+$"
},
"sort": {
"type": [
@@ -42337,7 +42337,7 @@
},
"type": {
"type": "string",
- "pattern": "^[a-zA-Z\\/\\-*]+$"
+ "pattern": "^[a-zA-Z/\\-*]+$"
}
}
}
@@ -74628,7 +74628,7 @@
},
"name": {
"type": "string",
- "pattern": "^[^\\s:\\/?#\\[\\]@!$&'()*+,;=\\\\%\\x00-\\x20]{1,256}$",
+ "pattern": "^[^\\s:/?#[\\]@!$&'()*+,;=\\\\%\\x00-\\x20]{1,256}$",
"minLength": 1
},
"summary": {
@@ -75699,7 +75699,7 @@
},
"name": {
"type": "string",
- "pattern": "^[^\\s:\\/?#\\[\\]@!$&'()*+,;=\\\\%\\x00-\\x20]{1,256}$",
+ "pattern": "^[^\\s:/?#[\\]@!$&'()*+,;=\\\\%\\x00-\\x20]{1,256}$",
"minLength": 1
},
"summary": { |
5 tasks
Contributor
Backend Memory Usage Comparison
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #16983 +/- ##
===========================================
+ Coverage 62.84% 68.13% +5.29%
===========================================
Files 1150 913 -237
Lines 115224 103713 -11511
Branches 7893 4172 -3721
===========================================
- Hits 72407 70660 -1747
+ Misses 40658 33013 -7645
+ Partials 2159 40 -2119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Member
Author
|
preferがundefinedになってるという問題になってますが、esmoduleの仕様からしてそうはならないのでvitestのバグを踏んでる...? |
Contributor
以前ioのフォークで試した際にorganizeImportsの順番でaccount.tsの$iに対してReferenceErrorが発生するケースを確認してますので、同じケースかもしれません |
Member
Author
|
recursive importの処理あたりなのかなぁ...情報ありがとうございます。 |
This was referenced Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
biomejsをlinterとして使う実験を行いました。
コーディングスタイル周りは biomejs は prettier と同様に opinioned なのでどうしようか悩んでます
Why
linterが遅いからそれの改善
Additional info (optional)
Checklist