enable and fix no-unused-vars and no-async-promise-executor#17070
Merged
syuilo merged 4 commits intomisskey-dev:developfrom Jan 8, 2026
Merged
enable and fix no-unused-vars and no-async-promise-executor#17070syuilo merged 4 commits intomisskey-dev:developfrom
syuilo merged 4 commits intomisskey-dev:developfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #17070 +/- ##
===========================================
+ Coverage 63.19% 63.26% +0.06%
===========================================
Files 1154 1156 +2
Lines 115410 115605 +195
Branches 8023 8072 +49
===========================================
+ Hits 72939 73139 +200
- Misses 40305 40318 +13
+ Partials 2166 2148 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Backend Memory Usage Comparison
|
Contributor
|
このPRによるapi.jsonの差分 |
Member
|
🙏🏻 |
m10i-0nyx
pushed a commit
to foundation0-link/misskey
that referenced
this pull request
Feb 7, 2026
…dev#17070) * dev: set --no-bail for lint task * lint: enable no-async-promise-executor lint and fix them * lint: enable no-unused-vars with allowing _ prefix * lint: fix semi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
タイトルの通り。
(Port from #16983)
Why
lint を修正するため。no-async-promise-executorに関してはエラーハンドリングの穴を作ることになり、最悪unhandled promise rejectionでプロセスクラッシュを引き起こすので修正。
Additional info (optional)
Checklist