refactor: use TRANSIENT scope to avoid service bucket relay#16985
Merged
syuilo merged 5 commits intomisskey-dev:developfrom Dec 22, 2025
Merged
refactor: use TRANSIENT scope to avoid service bucket relay#16985syuilo merged 5 commits intomisskey-dev:developfrom
syuilo merged 5 commits intomisskey-dev:developfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #16985 +/- ##
===========================================
- Coverage 62.83% 62.80% -0.04%
===========================================
Files 1150 1150
Lines 115228 114912 -316
Branches 7892 7870 -22
===========================================
- Hits 72400 72165 -235
+ Misses 40668 40604 -64
+ Partials 2160 2143 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
このPRによるapi.jsonの差分 |
Contributor
Backend Memory Usage Comparison
|
Member
Author
|
同様のことが apResolver 周りでもできるはずです |
0b1b084 to
a808e2d
Compare
Member
Author
|
apResolverのほうも ready |
Member
|
👍 |
m10i-0nyx
pushed a commit
to foundation0-link/misskey
that referenced
this pull request
Feb 7, 2026
…dev#16985) * refactor: use TRANSIENT scope to avoid service bucket relay * lint: fix lints * refactor: use transient for apResolver * Update packages/backend/src/core/activitypub/models/ApImageService.ts * fix
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
TRANSIENTスコープの
@Injectableを使用することで、Channelの依存となる service をバケツリレーしないでいいように、つまり今後のChannelの拡張を容易にしました。#16983 をやってる最中に少し思ったのでやってみました。
ある程度の動作確認はローカルで実行しました
Why
Additional info (optional)
Checklist