Skip to content

chore: delete unused ChannelsService#17218

Merged
kakkokari-gtyih merged 1 commit intodevelopfrom
fix-unnecessary-chammel-service
Mar 5, 2026
Merged

chore: delete unused ChannelsService#17218
kakkokari-gtyih merged 1 commit intodevelopfrom
fix-unnecessary-chammel-service

Conversation

@anatawa12
Copy link
Member

What

#16985 で使わなくなってたんですが、ファイルの削除を忘れてたのでそれです。

Why

シンプルに無駄。downstreamが誤解する

Additional info (optional)

内部的な変更なので no changelog entry

search result (定義1件のみ)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 5, 2026
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Mar 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.51%. Comparing base (a025209) to head (9b5559b).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #17218       +/-   ##
============================================
+ Coverage    13.90%   63.51%   +49.61%     
============================================
  Files          241     1160      +919     
  Lines        11690   115912   +104222     
  Branches      3951     8346     +4395     
============================================
+ Hits          1625    73620    +71995     
- Misses        7901    40087    +32186     
- Partials      2164     2205       +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Backend memory usage comparison

Before GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 322.66 MB 330.89 MB +8.23 MB +2.55%
VmHWM 322.66 MB 330.89 MB +8.23 MB +2.55%
VmSize 23115.74 MB 23124.71 MB +8.96 MB +0.03%
VmData 1385.99 MB 1395.04 MB +9.04 MB +0.65%

After GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 322.66 MB 330.93 MB +8.26 MB +2.56%
VmHWM 322.66 MB 330.93 MB +8.26 MB +2.56%
VmSize 23115.74 MB 23124.79 MB +9.04 MB +0.03%
VmData 1385.99 MB 1395.12 MB +9.13 MB +0.65%

After Request

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 323.06 MB 331.33 MB +8.26 MB +2.55%
VmHWM 323.06 MB 331.33 MB +8.26 MB +2.55%
VmSize 23115.83 MB 23124.87 MB +9.04 MB +0.03%
VmData 1386.07 MB 1395.20 MB +9.12 MB +0.65%

See workflow logs for details

@kakkokari-gtyih kakkokari-gtyih changed the title chore: delete ChannelsService which is unused chore: delete unused ChannelsService Mar 5, 2026
@kakkokari-gtyih kakkokari-gtyih merged commit 5d78b32 into develop Mar 5, 2026
39 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in [実験中] 管理用 Mar 5, 2026
@kakkokari-gtyih kakkokari-gtyih deleted the fix-unnecessary-chammel-service branch March 5, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend Server side specific issue/PR size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

2 participants