feat: Phase 3 — sync remaining calc engine modules with upstream#12
Merged
kokagex merged 10 commits intopob2macos_stage2from Feb 19, 2026
Merged
feat: Phase 3 — sync remaining calc engine modules with upstream#12kokagex merged 10 commits intopob2macos_stage2from
kokagex merged 10 commits intopob2macos_stage2from
Conversation
Sync 11 calc/engine files from upstream/dev, plus 2 caller fixes: Wholesale replacements (6): - CalcSections, Calcs, CalcTools, BuildDisplayStats, CalcBreakdown, BuildSiteTools Manual merges preserving local patches (5): - Data.lua: metatable guards + weaponType aliases - Common.lua: UTF-8 validator + nil guards - ModTools.lua: formatTag mixed-key sort comparator - StatDescriber.lua: upstream io.open (pcall no longer needed) - BuildList.lua: screenScale, i18n.t(), textInputActive guard Caller fixes: - SkillsTab.lua, GemSelectControl.lua: getGemStatRequirement arg order (level, multi, isSupport) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Upstream sync accidentally removed: - data.rebuildItemListLabels() for item/base name translation - StatDescriber i18n.lookup() for stat description translation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…peList
Upstream changed itemBaseTypeList from table-of-tables to string array.
Promote string entries to {name, label} tables on i18n rebuild so
DropDownControl can display translated labels while consumers still
access .name for lookup keys.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Upstream's io.open uses relative path without src/ prefix, but LoadModule prepends src/ while io.open resolves from CWD (Contents/Resources/). Add src/ prefix so specific skill stat description files are found correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- ItemTools.formatModLine: translate item mod lines via translateModLine - GemSelectControl: translate gem stat description lines as fallback - PassiveTreeView: translate tree node stat lines when sd_display missing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add Phase 3 sync details and document remaining i18n translation dictionary work needed for ja_stat_descriptions and ja_mod_stat_lines. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… labels Upstream CalcSections adds new label keys not yet in ja locale calcs section. Fall back to English label when i18n.lookup returns nil. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add Japanese translations for all new upstream CalcSections labels including Spirit, Deflection, Freeze Buildup, Charm, Mark, and other PoE2-specific stats. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- StatDescriber: add m_floor alias, fix undefined floor() call - CalcSections: fix duplicate notFlag → notFlagList for Eff. Source Rate - CalcSections: fix modName table syntax for MindOverMatter (Phys/Cold/Fire) - CalcTools: restore nil guard for multi in getGemStatRequirement - BuildSiteTools: add trailing newline Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PathOfBuildingCommunity/PathOfBuilding-PoE2dev branchgetGemStatRequirementargument order in SkillsTab.lua and GemSelectControl.lua to match upstream signature(level, multi, isSupport)Local patches preserved
setmetatableguards forcharacterConstants/monsterConstants, weaponTypeInfo legacy aliasescopyTable/pairsSortByKeynil guardsformatTagmixed key type sort comparatorscreenScale * sHiDPI scaling,i18n.t()labels,textInputActivekeyboard guardTest plan
luajit -blsyntax check on all 13 files (passed)🤖 Generated with Claude Code