Conversation
f962337 to
0164616
Compare
|
By the way, I wasn't planning on updating |
… reversal, FIXME)
inducer
left a comment
There was a problem hiding this comment.
Thanks for working on this!
By the way, I wasn't planning on updating make_face_restriction as part of this PR. It's quite a large chunk of code I don't understand..
See alexfikl#1 for "how hard could it possibly be". :)
Implement tensor product face restrictions
Co-authored-by: Andreas Klöckner <inform@tiker.net>
c6305e9 to
13decc1
Compare
0d3b7e5 to
bef4afb
Compare
|
Implemented mesh refinement for tensor product too. It turned out to be a bit big, so it's at alexfikl#3. |
|
CI fails should get fixed by #96. |
inducer
left a comment
There was a problem hiding this comment.
Thanks for working on this. This is 99.99% ready to go in my view. One concern, the rest of my comments are pretty superficial.
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Co-authored-by: Andreas Klöckner <inform@tiker.net>
|
Re-runing inducer/grudge#35 and inducer/pytential#44 with latest changes. |
Implements a couple of small things for tensor products:
face_vertex_indicesthat seems to allow building up the facial adjacency_test_node_vertex_consistencymake_face_restriction.modepy(needs Implement the face mass matrices for tensor products modepy#16).Some remaining things to do: