Skip to content

Comments

Tensor Product Additions#70

Merged
inducer merged 61 commits intoinducer:masterfrom
alexfikl:tensor-product-additions
Dec 23, 2020
Merged

Tensor Product Additions#70
inducer merged 61 commits intoinducer:masterfrom
alexfikl:tensor-product-additions

Conversation

@alexfikl
Copy link
Collaborator

@alexfikl alexfikl commented Oct 31, 2020

Implements a couple of small things for tensor products:

Some remaining things to do:

@alexfikl alexfikl force-pushed the tensor-product-additions branch from f962337 to 0164616 Compare October 31, 2020 02:28
@alexfikl
Copy link
Collaborator Author

By the way, I wasn't planning on updating make_face_restriction as part of this PR. It's quite a large chunk of code I don't understand..

Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

By the way, I wasn't planning on updating make_face_restriction as part of this PR. It's quite a large chunk of code I don't understand..

See alexfikl#1 for "how hard could it possibly be". :)

alexfikl and others added 3 commits November 3, 2020 14:26
Implement tensor product face restrictions
Co-authored-by: Andreas Klöckner <inform@tiker.net>
@alexfikl alexfikl force-pushed the tensor-product-additions branch from c6305e9 to 13decc1 Compare November 4, 2020 15:29
@alexfikl alexfikl force-pushed the tensor-product-additions branch from 0d3b7e5 to bef4afb Compare December 3, 2020 21:42
@alexfikl
Copy link
Collaborator Author

alexfikl commented Dec 6, 2020

Implemented mesh refinement for tensor product too. It turned out to be a bit big, so it's at alexfikl#3.

@inducer
Copy link
Owner

inducer commented Dec 10, 2020

CI fails should get fixed by #96.

Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. This is 99.99% ready to go in my view. One concern, the rest of my comments are pretty superficial.

@alexfikl
Copy link
Collaborator Author

Re-runing inducer/grudge#35 and inducer/pytential#44 with latest changes.

@alexfikl alexfikl requested a review from inducer December 22, 2020 18:53
Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Made a small tweak (0c10f6b). Ready to go from my end, I'll merge after CI passes.

@inducer inducer merged commit 882cd00 into inducer:master Dec 23, 2020
@alexfikl alexfikl mentioned this pull request Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants