Merged
Conversation
Contributor
Author
|
Also, inducer/meshmode#70 is currently running a CI with this branch, so that should hopefully scream if this managed to change the order in weird ways. |
inducer
reviewed
Nov 11, 2020
inducer
reviewed
Nov 11, 2020
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Thanks! This is much nicer than the crappy process by which I obtained the original node tuples. LGTM aside from my one comment.
alexfikl
force-pushed
the
contrib-node-order
branch
from
a26e5e9 to
ba9faaf
Compare
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds all the complete high-order elements supported by gmsh (for triangles, tets, quads and hexes at least).
The triangle and tet node tuples all match for the orders that were already there.
The quads and hexes are not the same though and I'm not sure if that changed in some gmsh version or was always off. The new node tuples fix the hex mesh generation I was seeing in meshmode here.