Implement the face mass matrices for tensor products#16
Merged
inducer merged 71 commits intoinducer:masterfrom Dec 11, 2020
Merged
Implement the face mass matrices for tensor products#16inducer merged 71 commits intoinducer:masterfrom
inducer merged 71 commits intoinducer:masterfrom
Conversation
alexfikl
commented
Nov 4, 2020
alexfikl
commented
Nov 4, 2020
alexfikl
commented
Nov 4, 2020
inducer
reviewed
Nov 14, 2020
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Thanks! Some comments/ideas below. Let me know what you think.
4 tasks
inducer
reviewed
Dec 2, 2020
alexfikl
commented
Dec 2, 2020
inducer
added a commit
to inducer/meshmode
that referenced
this pull request
Dec 2, 2020
This was referenced Dec 3, 2020
alexfikl
commented
Dec 3, 2020
inducer
reviewed
Dec 4, 2020
inducer
reviewed
Dec 4, 2020
inducer
approved these changes
Dec 11, 2020
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Looking good! Two minor things, I'll deal with them.
Owner
|
Thanks for seeing this through! |
Collaborator
Author
Yeah, this was a big one! That title is not even remotely accurate anymore! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few of things are added here:
modepy.shapesto define the various supported reference elements, for now simplices and hypercubes.The version was bumped to
2020.3too.