[newchem-cpp] mv grtest machinery into its own subdirectory #469
+183
−84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be reviewed after #471 has been merged
This has been on my todo list for quite a while.
This PR primarily makes 3 interrelated changes pertaining to the
grtestmachinery1:grtestmachinery its now calledgrtestutilstests/unitintotest/grtestutilsgrtestutilsortestdeps, we now link them all againsttestdepsThis PR also:
grtestutils/cmd.cpp(it reduces code duplication)gmocklibrary. While this doesn't have an immediate payoff, it will be a benefit for PR [newchem-cpp] cleanuptest_status_reporting.cpp#472 and another PR. To be clear: THIS DOES NOT INTRODUCE ANY DEPENDENCIES2Footnotes
Recall: the
grtestmachinery defines logic used to help implement unit tests. ↩For added context, the
gmocklibrary is a component of googletest that is already being compiled as part of googletest. In other words,gmockwas already an implicit dependency. By making it an explicit dependency, our test-code can access additional "matcher" functionality. (This functionality is most useful for testing strings and "containers") ↩