[newchem-cpp] Adjust API tests (factor out preset-fixtures and add basic ratequery tests) #468
+838
−216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be reviewed after #469
This PR basically does 2 things:
If factors out some logic from the
test_ghost_zone.cpptests and polishes it. This logic implements a fixture that:chemistry_data,chemistry_data_storage, andcode_unitsusing some "presets" before a testUses this machinery to help implement some basic tests for the ratequery API. (A bunch of these tests were informed by a PR that I'm working on in parallel)
Note
Aside: while the
IteratorAdaptormachinery seems a little like its overkill, it comes in handy for iterating over theratequeryaccessible rate names in this PR and subsequent PRs.It also lets us implement iteration over dynamically-accessible chemistry parameters (e.g. see the tests introduced in #470)