Skip to content

[newchem-cpp] ratequery-api: refactor and query properties #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mabruzzo wants to merge 29 commits into
base: newchem-cpp
Choose a base branch
from
Open

[newchem-cpp] ratequery-api: refactor and query properties #474

mabruzzo wants to merge 29 commits into from
+1,840 −526

Conversation

@mabruzzo
Copy link
Collaborator

@mabruzzo mabruzzo commented Dec 19, 2025

To be reviewed after #468 has been merged

This PR does a few things:

  1. we now track the tables of information that ratequery tracks directly as part of chemistry_data_storage in the new Registry type
  2. I have added a function to let us query some basic properties of the rates
    • right now, we primarily query number of dimensions and shape
    • in a followup PR, we'll also query the datatype
  3. I have added a function to let us directly query the number of accessible rates
  4. I have done some light refactoring of the gracklepy wrapper
  5. I have added a bunch of new googletest tests for the ratequery machinery

@mabruzzo
address compiler warning in chemistry_solver_funcs.hppp
e4df3f9
@mabruzzo
address warning about uninitialized variables in solve_rate_cool_g-cp…
e2ea0d9 
…p.cpp
@mabruzzo
mv testing utility library from tests/unit to tests/grtestutils
9ff4b3a
@mabruzzo
slightly alter we define targets that support testing
b5b7e65
@mabruzzo
address a todo item (to reduce code duplication)
8cae777
@mabruzzo
Add gmock to the list of libraries linked via testdeps
5cf43bc 
For context, the gmock library is a component of googletest (it's
already being installed). All this commit does is make it possible for
us to use it in subsequent PRs
@mabruzzo
mv GrackleCtxPack out of test_ghost_zone and refactor
deb6c84
@mabruzzo
transfer grtest_api_fixture out of test_ghost_zone
c4495e7
@mabruzzo
introduce some basic tests of ratequery
268b9b4
@mabruzzo
add more ratequery tests
cd7deac
@mabruzzo
tweak the name of the test_ghost_zone tests
2425701
@mabruzzo
factor out machinery for creating adaptor
37fad17
@mabruzzo
fix a broken header include
39e1c0c
@mabruzzo
some light refactoring of the rate utlities
804efcf
@mabruzzo
rename rateprop -> ratequery::Descr (as in a rate description)
ff9eca6
@mabruzzo
slightly more refactoring
9a32a9e
@mabruzzo
tweak signatures of grunstable_(ratequery_id|ith_rate)
d13591e
@mabruzzo
rename rate_utils to ratequery
1fff13c
@mabruzzo
rename Descr->Entry
3659a3a
@mabruzzo
introduce ratequery.hpp
11ddf78
@mabruzzo
Store the Entry Registry within chemistry_data_storage
fb030ff
@mabruzzo
lay the foundation for querying properties
e42e0dd
@mabruzzo
gracklepy: start directly querying shapes
97d3ce6
@mabruzzo
gracklepy: use new shape query logic
ab816b4
@mabruzzo
Tweak grackle wrapper
080a097 
This change ensures that the chemistry_data extension type will provide
a consistent set of attributes, even if we make unused rate information
inaccessible through the ratequery interface
@mabruzzo
remove unimplemented rate properties
3a95ef0
@mabruzzo
address a gcc compiler warning
5df10fc
@mabruzzo
introduce grunstable_ratequery_nrates
fe1aba6
@mabruzzo
add some tests that query rates
93c4c74
@mabruzzo mabruzzo mentioned this pull request Dec 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

New Chemistry and C++ Transcription
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mabruzzo