Skip to content

Conversation

@mabruzzo
Copy link
Collaborator

To be reviewed after #469 has been merged


This does 3 things:

  1. it deletes an unused function and some commented-out logic (not sure how I previously let that stuff slip through the cracks)
  2. it simplifies a bunch of checks using gmock "matchers" that were enabled by [newchem-cpp] mv grtest machinery into its own subdirectory #4691
  3. it turns on clang-format for test_status_reporting.cpp

Footnotes

  1. For added context, googletest was previously being compiled with gmock. In fact the "DEATH TESTS" in this file make use of regex statements to match error messages. The main difference is that we are now using gmock directly ([newchem-cpp] mv grtest machinery into its own subdirectory #469 made this possible by explicitly linking test-code again the gmock library)

@mabruzzo mabruzzo added testing test suite, regression tests, ci infrastructure refactor internal reorganization or code simplification with no behavior changes labels Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor internal reorganization or code simplification with no behavior changes testing test suite, regression tests, ci infrastructure

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant