Skip to content

feat(proguard): Mark synthesized methods on frames#1735

Merged
loewenheim merged 2 commits intomasterfrom
sebastian/proguard-synthesized
Jul 17, 2025
Merged

feat(proguard): Mark synthesized methods on frames#1735
loewenheim merged 2 commits intomasterfrom
sebastian/proguard-synthesized

Conversation

@loewenheim
Copy link
Copy Markdown
Contributor

Depends on #1734. This adds a field method_synthesized to JvmFrame that denotes whether the frame's method was synthesized by the compiler.

Closes #1720. Closes SYMBOLI-22.

@loewenheim loewenheim requested a review from a team as a code owner July 17, 2025 12:52
@linear
Copy link
Copy Markdown

linear bot commented Jul 17, 2025

Copy link
Copy Markdown

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Base automatically changed from sebastian/proguard-update to master July 17, 2025 13:10
Depends on #1734. This
adds a field `method_synthesized` to `JvmFrame` that denotes whether the
frame's method was synthesized by the compiler.
@loewenheim loewenheim force-pushed the sebastian/proguard-synthesized branch from 830cd56 to beca4ea Compare July 17, 2025 14:30
@loewenheim loewenheim enabled auto-merge (squash) July 17, 2025 14:30
@loewenheim loewenheim merged commit 20fc3be into master Jul 17, 2025
20 checks passed
@loewenheim loewenheim deleted the sebastian/proguard-synthesized branch July 17, 2025 14:40
loewenheim added a commit to getsentry/sentry that referenced this pull request Jul 22, 2025
As of getsentry/symbolicator#1735
Symbolicator returns a flag on Java stackframes with synthesized methods.
We carry over this flag and additionally mark such frames as not in-app.
loewenheim added a commit to getsentry/sentry that referenced this pull request Jul 22, 2025
As of getsentry/symbolicator#1735 Symbolicator
returns a flag on Java stackframes with synthesized methods. We carry
over this flag and additionally mark such frames as not in-app.

ref: #94408. ref: INGEST-432.
andrewshie-sentry pushed a commit to getsentry/sentry that referenced this pull request Aug 4, 2025
As of getsentry/symbolicator#1735 Symbolicator
returns a flag on Java stackframes with synthesized methods. We carry
over this flag and additionally mark such frames as not in-app.

ref: #94408. ref: INGEST-432.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proguard: Handle synthesized frames during symbolication

3 participants