Skip to content

feat(java): Mark frames with synthesized methods#96059

Merged
loewenheim merged 1 commit intomasterfrom
sebastian/proguard-synthesized
Jul 22, 2025
Merged

feat(java): Mark frames with synthesized methods#96059
loewenheim merged 1 commit intomasterfrom
sebastian/proguard-synthesized

Conversation

@loewenheim
Copy link
Copy Markdown
Contributor

As of getsentry/symbolicator#1735 Symbolicator returns a flag on Java stackframes with synthesized methods. We carry over this flag and additionally mark such frames as not in-app.

ref: #94408. ref: INGEST-432.

As of getsentry/symbolicator#1735
Symbolicator returns a flag on Java stackframes with synthesized methods.
We carry over this flag and additionally mark such frames as not in-app.
@linear
Copy link
Copy Markdown

linear bot commented Jul 22, 2025

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 22, 2025
@loewenheim loewenheim requested a review from a team July 22, 2025 09:14
@loewenheim loewenheim merged commit b5d077e into master Jul 22, 2025
65 checks passed
@loewenheim loewenheim deleted the sebastian/proguard-synthesized branch July 22, 2025 09:18
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/lang/java/processing.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #96059      +/-   ##
==========================================
+ Coverage   82.95%   87.79%   +4.84%     
==========================================
  Files       10607    10607              
  Lines      611447   611464      +17     
  Branches    24016    24016              
==========================================
+ Hits       507197   536860   +29663     
+ Misses     103965    74319   -29646     
  Partials      285      285              

andrewshie-sentry pushed a commit that referenced this pull request Aug 4, 2025
As of getsentry/symbolicator#1735 Symbolicator
returns a flag on Java stackframes with synthesized methods. We carry
over this flag and additionally mark such frames as not in-app.

ref: #94408. ref: INGEST-432.
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants